Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typos in models #164

Merged
merged 8 commits into from
Aug 25, 2023
Merged

fix: typos in models #164

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e391d95
Changed: event.py Fixed typo errors in Event(BaseModel) achievement: …
EnricoBaivo Aug 24, 2023
2ad8cbb
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 24, 2023
c50b394
Fixed: Achievement class parameter mode is a optional Field, possible…
EnricoBaivo Aug 24, 2023
97bac22
chore: remove unrelated changes in .gitignore
NiceAesth Aug 25, 2023
bb1aea3
chore: revert unrelated change
NiceAesth Aug 25, 2023
e0dbe07
Update .gitignore
NiceAesth Aug 25, 2023
ba3930c
chore: fix pr
NiceAesth Aug 25, 2023
0b2e43e
chore: fix pr
NiceAesth Aug 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ share/python-wheels/
.installed.cfg
*.egg
MANIFEST

.gitigonre
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not do unrelated changes in prs

.pre-commit-config.yaml
# PyInstaller
# Usually these files are written by a python script from a template
# before PyInstaller builds the exe, so as to inject date/other infos into it.
Expand Down
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,4 +42,4 @@ repos:
- id: poetry-check

default_language_version:
python: python3.9
python: python3.11
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not do unrelated changes in prs

4 changes: 2 additions & 2 deletions aiosu/models/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,10 @@ class Achievement(BaseModel):
id: int
name: str
slug: str
desciption: str
description: str # typo desciption
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

grouping: str
icon_url: str
mode: Gamemode
mode: Optional[Gamemode] = None
ordering: int
instructions: Optional[str] = None

Expand Down
2 changes: 1 addition & 1 deletion aiosu/models/event.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ class Event(BaseModel):
type: EventType
r"""Information on types: https://github.com/ppy/osu-web/blob/master/resources/assets/lib/interfaces/event-json.ts"""
parse_error: Optional[bool] = None
achievment: Optional[Achievement] = None
achievement: Optional[Achievement] = None # typo achievment
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not add comments like these to the code

user: Optional[EventUser] = None
beatmap: Optional[EventBeatmap] = None
beatmapset: Optional[EventBeatmapset] = None
Expand Down