Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] QueryFunTokenMapping Returns Invalid erc20Addr - Non-Hex, Non-ETH Address #392

Closed
CalicoNino opened this issue Nov 28, 2024 · 0 comments · Fixed by NibiruChain/nibiru#2120
Assignees
Labels
prio: p0 (critical) critical/urgent priority S-triage Status: This issue is waiting on initial triage. More Info: https://tinyurl.com/25uty9w5

Comments

@CalicoNino
Copy link
Contributor

With QueryFunTokenMapping, the resulting erc20Addr ends up being a non hex, non eth addr
Example:

{
  funToken: {
    erc20Addr: 'ʊﵻ\ude0b\ude92\udd0c\udc29\x00얻?\n{',
    bankDenom: 'tf/nibi1tf6lpa5h8m5fuh8u3vpgm0cvwr7ld090ex30ny/urexx',
    isMadeFromCoin: true
  }
}

This is more difficult to trace back since we just perform a request and decode the result

  FunTokenMapping(request: QueryFunTokenMappingRequest): Promise<QueryFunTokenMappingResponse> {
    const data = QueryFunTokenMappingRequest.encode(request).finish();
    const promise = this.rpc.request(this.service, "FunTokenMapping", data);
    return promise.then((data) => QueryFunTokenMappingResponse.decode(_m0.Reader.create(data)));
  }

Although, we can note that FunToken in ts Proto has erc20Addr as string as well

@CalicoNino CalicoNino self-assigned this Nov 28, 2024
@github-project-automation github-project-automation bot moved this to ⚡ Building 🧱 in ⚛️ Nibiru (Hougyoku) Nov 28, 2024
@CalicoNino CalicoNino added prio: p0 (critical) critical/urgent priority S-triage Status: This issue is waiting on initial triage. More Info: https://tinyurl.com/25uty9w5 labels Nov 28, 2024
@CalicoNino CalicoNino moved this from ⚡ Building 🧱 to ➡️ Pending Review/Merge in ⚛️ Nibiru (Hougyoku) Dec 6, 2024
@github-project-automation github-project-automation bot moved this from ➡️ Pending Review/Merge to ✅ Completed in ⚛️ Nibiru (Hougyoku) Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio: p0 (critical) critical/urgent priority S-triage Status: This issue is waiting on initial triage. More Info: https://tinyurl.com/25uty9w5
Projects
Status: ✅ Completed
Development

Successfully merging a pull request may close this issue.

1 participant