Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(wasmbinding)!: remove wasmbinding custom executors #1766

Merged
merged 6 commits into from
Jan 8, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions README.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change breaks the links for me

Original file line number Diff line number Diff line change
Expand Up @@ -8,16 +8,17 @@

**Nibiru Chain** is a breakthrough smart contract platform providing superior throughput, reduced latency, and improved security, all driven by Web Assembly (Wasm) smart contracts.

- [⚙️ — Documentation](#%EF%B8%8F--documentation)
- [💬 — Community](#--community)
- [🧱 — Components of Nibiru](#--components-of-nibiru)
- [⛓️ — Building: `make` commands](#%EF%B8%8F--building-make-commands)
- [Nibid CLI](#nibid-cli)
- [Running a Local Node](#running-a-local-node)
- [Generate the protobufs](#generate-the-protobufs)
- [Linter](#linter)
- [Multiple Nodes](#multiple-nodes)
- [License](#license)
- [Nibiru Chain](#nibiru-chain)
- [⚙️ — Documentation](#️--documentation)
- [💬 — Community](#--community)
- [🧱 — Components of Nibiru](#--components-of-nibiru)
- [⛓️ — Building: `make` commands](#️--building-make-commands)
- [Nibid CLI](#nibid-cli)
- [Running a Local Node](#running-a-local-node)
- [Generate the protobufs](#generate-the-protobufs)
- [Linter](#linter)
- [Multiple Nodes](#multiple-nodes)
- [License](#license)

## ⚙️ — Documentation

Expand Down Expand Up @@ -66,7 +67,6 @@ If you have questions or concerns, feel free to connect with a developer or comm
[code-x-oracle]: https://github.com/NibiruChain/nibiru/tree/main/x/oracle
[code-x-perp]: https://github.com/NibiruChain/nibiru/tree/main/x/perp
[code-x-spot]: https://github.com/NibiruChain/nibiru/tree/main/x/spot
[code-x-wasm]: https://github.com/NibiruChain/nibiru/tree/main/wasmbinding

Nibiru is built with the [Cosmos-SDK][cosmos-sdk-repo] on [Tendermint Core](https://tendermint.com/core/) consensus and communicates with other blockchain chains using the [Inter-Blockchain Communication (IBC)](https://github.com/cosmos/ibc) protocol.

Expand Down
11 changes: 0 additions & 11 deletions app/app.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,6 @@ import (
"github.com/prometheus/client_golang/prometheus"
"github.com/rakyll/statik/fs"
"github.com/spf13/cast"

wasmbinding "github.com/NibiruChain/nibiru/wasmbinding"
)

const (
Expand Down Expand Up @@ -115,15 +113,6 @@ func GetWasmOpts(nibiru NibiruApp, appOpts servertypes.AppOptions) []wasmkeeper.
wasmOpts = append(wasmOpts, wasmkeeper.WithVMCacheMetrics(prometheus.DefaultRegisterer))
}

// Add the bindings to the app's set of []wasmkeeper.Option.
wasmOpts = append(wasmOpts, wasmbinding.NibiruWasmOptions(
nibiru.GRPCQueryRouter(),
nibiru.appCodec,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stargate queries are still supposed to be there. If that part is removed, contracts can't use the query server at all.

So the only part to remove here is the keeper executor stuff, not the entire querier

nibiru.PerpKeeperV2,
nibiru.SudoKeeper,
nibiru.OracleKeeper,
)...)

return wasmOpts
}

Expand Down
1 change: 0 additions & 1 deletion app/keepers.go
Original file line number Diff line number Diff line change
Expand Up @@ -460,7 +460,6 @@ func (app *NibiruApp) InitKeepers(
govModuleAddr,
)

// TokenFactory has wasm bindings
app.TokenFactoryKeeper = tokenfactorykeeper.NewKeeper(
keys[tokenfactorytypes.StoreKey],
appCodec,
Expand Down
109 changes: 0 additions & 109 deletions wasmbinding/bindings/execute_msg.json

This file was deleted.

97 changes: 0 additions & 97 deletions wasmbinding/bindings/marshalling_test.go

This file was deleted.

69 changes: 0 additions & 69 deletions wasmbinding/bindings/msg.go

This file was deleted.

Loading
Loading