Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CallContractWithInput does not update block booom filter with EVM logs #2082

Closed
Unique-Divine opened this issue Oct 17, 2024 · 1 comment
Closed
Labels
S-triage Status: This issue is waiting on initial triage. More Info: https://tinyurl.com/25uty9w5

Comments

@Unique-Divine
Copy link
Member

Abstract / Summary

Scope: x/evm/keeper/erc20.go

The internal EVM call in CallContractWithInput() does not update the block bloom filter with the emitted EVM logs.

Contrary to ApplyEvmTx in

if len(receipt.Logs) > 0 {
// Update transient block bloom filter
k.EvmState.BlockBloom.Set(ctx, receipt.Bloom.Bytes())
blockLogSize := uint64(txConfig.LogIndex) + uint64(len(receipt.Logs))
k.EvmState.BlockLogSize.Set(ctx, blockLogSize)
}

Originally posted by @berndartmueller in https://github.com/code-423n4/2024-10-nibiru-zenith/pull/12#discussion_r1804304715


@github-project-automation github-project-automation bot moved this to ⚡ Building 🧱 in ⚛️ Nibiru (Hougyoku) Oct 17, 2024
@github-actions github-actions bot added the S-triage Status: This issue is waiting on initial triage. More Info: https://tinyurl.com/25uty9w5 label Oct 17, 2024
@Unique-Divine
Copy link
Member Author

@github-project-automation github-project-automation bot moved this from ⚡ Building 🧱 to ✅ Completed in ⚛️ Nibiru (Hougyoku) Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-triage Status: This issue is waiting on initial triage. More Info: https://tinyurl.com/25uty9w5
Projects
Archived in project
Development

No branches or pull requests

1 participant