Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[evm] Refactor out dead code from the evm.Params #2064

Closed
3 tasks done
Unique-Divine opened this issue Oct 5, 2024 · 0 comments · Fixed by #2065
Closed
3 tasks done

[evm] Refactor out dead code from the evm.Params #2064

Unique-Divine opened this issue Oct 5, 2024 · 0 comments · Fixed by #2065
Labels
x: evm Relates to Nibiru EVM or the EVM Module

Comments

@Unique-Divine
Copy link
Member

Unique-Divine commented Oct 5, 2024

Context

Current evm.Params structure (commit: 37913c4):

// From evm/params.go

func DefaultParams() Params {
	return Params{
		EvmDenom:            DefaultEVMDenom,
		ExtraEIPs:           []int64{},
		AllowUnprotectedTxs: false,
		EVMChannels:         []string{},
		CreateFuntokenFee:   math.NewIntWithDecimal(10_000, 6), // 10_000 NIBI
	}
}
  • EvmDenom should be a consant since we're highly unlikely to ever change to
    anything besides NIBI, and having it flexible exposes the network to a governance
    attack that messes up the economics of Nibiru's EVM by switching the denom to a
    different bank coin.
  • AllowUnprotectedTxs is always false. We should remove it
  • EVMChannels is unused, as it was intended for extending the module with
    IBC functionality. We should document why it exists.
@github-project-automation github-project-automation bot moved this to ⚡ Building 🧱 in ⚛️ Nibiru (Hougyoku) Oct 5, 2024
@github-actions github-actions bot added the S-triage Status: This issue is waiting on initial triage. More Info: https://tinyurl.com/25uty9w5 label Oct 5, 2024
@Unique-Divine Unique-Divine added x: evm Relates to Nibiru EVM or the EVM Module and removed S-triage Status: This issue is waiting on initial triage. More Info: https://tinyurl.com/25uty9w5 labels Oct 5, 2024
@github-project-automation github-project-automation bot moved this from ⚡ Building 🧱 to ✅ Completed in ⚛️ Nibiru (Hougyoku) Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x: evm Relates to Nibiru EVM or the EVM Module
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant