Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

epic(wasm): Removal of CosmosMsg::Custom bindings in favor of MsgServer + CosmosMsg::StargateMsg #1642

Closed
5 tasks done
jgimeno opened this issue Oct 18, 2023 · 3 comments · Fixed by NibiruChain/nibiru-wasm#100
Closed
5 tasks done

epic(wasm): Removal of CosmosMsg::Custom bindings in favor of MsgServer + CosmosMsg::StargateMsg #1642

jgimeno opened this issue Oct 18, 2023 · 3 comments · Fixed by NibiruChain/nibiru-wasm#100
Assignees
@Unique-Divine
Labels
epic Project or large task that groups multiple tickets and PRs

Comments

@jgimeno
Copy link
Contributor

jgimeno commented Oct 18, 2023 •
edited by Unique-Divine
Loading

(Update 2023-12) Reopening with more accurate description
@Unique-Divine
Copy link
Member

Unique-Divine commented Oct 18, 2023 •
edited
Loading

It's a convention taking after the bindings used by Terra and Injective. You don't have to use the route. It's more to clarify what module the message interacts with.

For example, the function create_deposit_msg sets InjectiveRoute:::Exchange since having a message InjectiveMsg::Deposit is somewhat ambiguous.

@jgimeno, LMK if you still would like to remove it given the added context. It's a pretty quick ticket we can do in the upcoming sprint.

@Unique-Divine Unique-Divine moved this to ⚡ In Progress 🧱 in ⚛️ Nibiru (Hougyoku) Dec 3, 2023
@Unique-Divine Unique-Divine mentioned this issue Dec 4, 2023
Merged
Unique-Divine added a commit to NibiruChain/nibiru-wasm that referenced this issue Dec 4, 2023
@Unique-Divine
epic: new protobufs, revive nibi-stargate-perp, and cleanup: cw-nibir…
d966563 
…u#100

epic: new protobufs, revive nibi-stargate-perp, and cleanup

## Context

- Closes #49: The `core-shifter` smart contract now uses `cw-ownable` and has a cleaner permissions abstraction.
- Closes NibiruChain/nibiru#1580
- Closes NibiruChain/nibiru#1642: The `NibiruRoute` enum was removed everywhere.
- Builds new wasm bytecode artifacts
- Published `nibiru-std` v0.0.3

### Commit Log

- feat(scripts-proto-clean): handlers for nibiru proto cleaning + more tests
- chore(deps): update Cargo.lock
- feat(nibiru-std): new protobuf types
- chore(deps-nibi-stargate): update deps to workspace
- chore(nibiru-std): rm bindings
- feat(nibiru-std): add prost::Name impls for new protobuf types
- feat(nibi-stargate-perp): revive perp bindings contract using CosmosMsg::Stargate
- refactor(nusd-valuator): run tidy
- fix(core-shifter): use new types + clean up tests
- fix(core-controller): use new types + clean up tests [deprecated temp]
- feat(core-shifter): use cw-ownable, set_contract_version, better perission abstraction
- refactor(core-shifter)!: make CanExecute logic more concise + tests
- refactor(contracts): mv core-controller to packages to prevent contract build
- refactor(core-shifter): make tests more concise and easy to follow
- chore(artifacts): build all contracts
- chore(nibiru-std): impl NibiruStargateMsg and NibiruStargateQuery: cosmos bank, cosmos auth
- chore(nibiru-std): impl NibiruStargateMsg and NibiruStargateQuery: cosmos gov
- feat(nibiru-std-proto): add pub mod definitions for many modules
- feat(nibiru-std): trait impls for NibiruChain/nibiru#1580
- refactor: remove unnecessary imports of nibiru-macro
- fix(nibiru-std): fix build by deleting prost::OneOf type in cosmos.staking
- ci: add codecov.yml
@github-project-automation github-project-automation bot moved this from ⚡ Building 🧱 to ✅ Completed in ⚛️ Nibiru (Hougyoku) Dec 4, 2023
@Unique-Divine Unique-Divine changed the title Wasm Route in wasmbindings is not used epic(wasm): Removal of CosmosMsg::Custom bindings in favor of MsgServer + CosmosMsg::StargateMsg Dec 19, 2023
@Unique-Divine Unique-Divine added epic Project or large task that groups multiple tickets and PRs type: enhancement labels Dec 19, 2023
@Unique-Divine Unique-Divine moved this from ✅ Completed to ⚡ Building 🧱 in ⚛️ Nibiru (Hougyoku) Dec 19, 2023
@Unique-Divine
Copy link
Member

Unique-Divine commented Dec 19, 2023 •
edited
Loading

Reopening with more accurate description

@Unique-Divine Unique-Divine reopened this Dec 19, 2023
@Unique-Divine Unique-Divine mentioned this issue Dec 28, 2023
Merged
@Unique-Divine Unique-Divine self-assigned this Dec 28, 2023
@Unique-Divine
Copy link
Member

Unique-Divine commented Dec 28, 2023 •
edited
Loading

cc @jgimeno , you mentioned in Slack that you'd like to work on this issue. You could add SetMarketEnabled or CreateMarket to the x/perp MsgServer

@Unique-Divine Unique-Divine mentioned this issue Dec 29, 2023
Merged
jgimeno pushed a commit that referenced this issue Jan 1, 2024
@Unique-Divine
feat(perp): MsgWithdrawFromPerpFund sudo call as part of #1642 (#1734)
310fcf1 
* feat(perp): MsgDonateToPerpFund

* changelog

* linter

* test assertiong

* test(perp-cli_test): Grab module acc addr programatically

* consistent naming with #1752
jgimeno added a commit that referenced this issue Jan 2, 2024
@jgimeno
feat(perp): move close market from Wasm Binding to MsgCloseMarket as …
b4175f1 
…part of #1642 (#1749)

* remove mentions of bindings for closing the market.

* create new message for Closing a Market

* temp commit

* add permissions to call the CloseMarket

* make lint

* it fails when closing market with other user

* update changelog
Unique-Divine added a commit that referenced this issue Jan 2, 2024
@Unique-Divine
feat(oracle): MsgEditOracleParams sudo tx msg as part of #1642 (#1752)
1795b55 
* feat(perp): MsgDonateToPerpFund

* changelog

* linter

* test assertiong

* Squashed commit of the following:

commit e43672a
Author: Unique-Divine <[email protected]>
Date:   Wed Dec 27 23:27:28 2023 -0600

    test assertiong

commit 0090d2f
Author: Unique-Divine <[email protected]>
Date:   Wed Dec 27 23:17:30 2023 -0600

    linter

commit 5121341
Merge: 596a840 68bddeb
Author: Unique-Divine <[email protected]>
Date:   Wed Dec 27 23:12:10 2023 -0600

    Merge branch 'main' into realu/sg-perp

commit 596a840
Author: Unique-Divine <[email protected]>
Date:   Wed Dec 27 23:10:15 2023 -0600

    changelog

commit 240dffe
Author: Unique-Divine <[email protected]>
Date:   Wed Dec 27 23:07:46 2023 -0600

    feat(perp): MsgDonateToPerpFund

* test(perp-cli_test): Grab module acc addr programatically

* impl wip! keeper version without msg server or protos

* quicksave wip! - add protos and msg server + todos

* test(oracle): verify that params before are not equal

* refactor: sudo and admin name consistency + docs + remove struct
embedding

* Squashed commit of the following:

commit d3f0ce3
Author: Unique-Divine <[email protected]>
Date:   Wed Dec 27 23:47:35 2023 -0600

    test(perp-cli_test): Grab module acc addr programatically

commit e43672a
Author: Unique-Divine <[email protected]>
Date:   Wed Dec 27 23:27:28 2023 -0600

    test assertiong

commit 0090d2f
Author: Unique-Divine <[email protected]>
Date:   Wed Dec 27 23:17:30 2023 -0600

    linter

commit 5121341
Merge: 596a840 68bddeb
Author: Unique-Divine <[email protected]>
Date:   Wed Dec 27 23:12:10 2023 -0600

    Merge branch 'main' into realu/sg-perp

commit 596a840
Author: Unique-Divine <[email protected]>
Date:   Wed Dec 27 23:10:15 2023 -0600

    changelog

commit 240dffe
Author: Unique-Divine <[email protected]>
Date:   Wed Dec 27 23:07:46 2023 -0600

    feat(perp): MsgDonateToPerpFund

* PR comments fix

* test(oracle): fix unit test case with invalid slash window
@matthiasmatt matthiasmatt mentioned this issue Jan 5, 2024
Merged
@github-project-automation github-project-automation bot moved this from ⚡ Building 🧱 to ✅ Completed in ⚛️ Nibiru (Hougyoku) Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Unique-Divine Unique-Divine

Labels
epic Project or large task that groups multiple tickets and PRs
Projects
⚛️ Nibiru (Hougyoku)
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

epic: new protobufs, revive nibi-stargate-perp, and cleanup NibiruChain/nibiru-wasm
2 participants
@jgimeno @Unique-Divine