Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Points to improve your code. #15

Open
MT-276 opened this issue Jul 22, 2023 · 0 comments
Open

Points to improve your code. #15

MT-276 opened this issue Jul 22, 2023 · 0 comments

Comments

@MT-276
Copy link

MT-276 commented Jul 22, 2023 •
edited
Loading

  1. Add comments to your code. It is kinda unreadable for a non-programmer.
  2. Why do you have a separate file for MP4-MP3 conversion function ? Just merge it into the functions file.
  3. If your code is open source then what is the point of your copyright ? Remove your copyright and add a "Free use" licence
  4. Add a GUI. Use tkinter. Should be pretty straight forward and easy to just add a simple UI for the options and the quality.
  5. Add a requirements.txt or mention the third-party libraries needed to be installed for this program to work.
  6. And finally listen to the pull requests. Some them are really good and can improve the overall experience of your project.

MT-276
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MT-276