Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix moved default storage dir outside the nethermind repo folder but authentication error in JSON-RPC request #7815

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Dhir0808
Copy link

Fix authentication error in JSON-RPC request

Fixes #7795

Changes

  • Updated the JSON-RPC request to include the correct authentication headers based on the XDG environment variables.
  • Implemented error handling to manage authentication failures gracefully.
  • Note: Unit tests for the new authentication logic have not yet been written.

Types of changes

  • Bugfix (a non-breaking change that fixes an issue)

Testing

Requires testing

  • Yes

If yes, did you write tests?

  • Yes
  • No

Notes on testing

  • Unit tests for verifying authentication error handling and header correctness are planned but not yet implemented.

Documentation

Requires documentation update

  • Yes
  • No

Requires explanation in Release Notes

  • Yes
  • No

@LukaszRozmej LukaszRozmej requested a review from rubo November 27, 2024 09:47
Copy link
Contributor

@rubo rubo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this. Commented on the issue.

@obasekiosa
Copy link
Contributor

@Dhir0808
you can modify this (change title and revert old commits and force push new commits) to simply to match the new direction.
no need for a new pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maybe move default storage dir outside nethermind repo folder?
3 participants