-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maybe move default storage dir outside nethermind repo folder? #7795
Comments
Hi @obasekiosa , I suggest changing the default storage directory to use the HOME directory or XDG paths (e.g., $XDG_DATA_HOME, $XDG_CONFIG_HOME). This would prevent data loss when deleting or updating the repo and avoid conflicts when running multiple client versions. It would also give users more control over where the data is stored. I would like to take this issue. |
@Dhir0808 I'd just link a couple of people. |
Hi so what I propose is so we can create a new class to handle the storage paths |
@Dhir0808 pick the approprained XDG* variable and reasonable fallbacks should they be empty. |
@obasekiosa I have tried to move the folder out can you have a look at it and suggest any changes, |
I have mixed feelings about this. While it may make sense in certain situations, it doesn't address a common issue. Previously, we had the |
@Dhir0808 this is actually quite good. What we would have wanted was to simply get the env variable and recursive fallbacks if any are empty and then set the Also we could do away with the "Nethermind" prefix when naming classes. But given @rubo concerns which i believe are valid. A better approach would be to just log a warning on startup that the default directory is being used [and would be lost on deleting the repo (might not make sense when using a compiled binary)]. |
@rubo @obasekiosa Thank you for the feedback! I will start to work on logging a warning on startup which is I feel a good solution to the problem. |
The priority is end-user experience, not the dev team. While the data directory should always be explicitly set, and showing a warning makes sense when it's not, I'd like to know the team's opinion about this. |
Is your feature request related to a problem? Please describe.
Deleting an entire repo implies deleting all storage data when nethermind client is ran from source.
Describe the solution you'd like
maybe have client use the HOME fould of XDG* paths for creating these directories.
Describe alternatives you've considered
Just let it be. it shouldn't be an issue.
allows running multiple versions of the code without worrying about data collision.
Additional context
None.
The text was updated successfully, but these errors were encountered: