Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Receipt.TxLookupLimit to 0 when pruning is disabled #6832

Open
svanegmond opened this issue Mar 14, 2024 · 1 comment
Open

Default Receipt.TxLookupLimit to 0 when pruning is disabled #6832

svanegmond opened this issue Mar 14, 2024 · 1 comment

Comments

@svanegmond
Copy link

svanegmond commented Mar 14, 2024

Is your feature request related to a problem? Please describe.

While operating a full archive node, transactions older than 2.3M blocks will no longer be returned by getTransactionByHash

Per discussion on Discord, this is expected:

me: "Is it right that a receipt being purged should cause getTransactionByHash to deny the existence of the tx? It can still be observed by fetching the block it’s contained in"

Ashraf: "it just does not save all of the txhash -> block mapping which take up a lof of space"). Full archive nodes already, self-evidently, don't care about space.

This was encountered while launching Gnosis Safe onto our chain, it simply would not index what I thought was a full archive node.

Describe the solution you'd like

Default the TxLookupLimit to 0 when Pruning is None.

Describe alternatives you've considered

I've asked safe-global to mention this specific requirement on https://docs.safe.global/advanced/api-rpc-requirements .

@svanegmond
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant