onDelete MetadataInterceptor (#582)

* onDelete metadata interceptor, use for deleting definitionMetadata * wip * clean up comments * call onDelete in user metadata svc --------- Co-authored-by: Amanda Bozigian <[email protected]>
Netflix · Apr 15, 2024 · ae08316 · ae08316
1 parent 06e703c
commit ae08316
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 5 deletions.
diff --git a/...ver/src/main/java/com/netflix/metacat/common/server/usermetadata/MetadataInterceptor.java b/...ver/src/main/java/com/netflix/metacat/common/server/usermetadata/MetadataInterceptor.java
@@ -33,7 +33,7 @@
 public interface MetadataInterceptor {
 
     /**
-     * apply business rules before retrieving back. These rules may change or overriding existing
+     * Apply business rules before retrieving back. These rules may change or override existing
      * business metadata.
      *
      * @param userMetadataService user metadata service
@@ -47,14 +47,25 @@ default void onRead(final UserMetadataService userMetadataService,
     }
 
     /**
-     * Valide ObjectNode before storing it.
+     * Validate ObjectNode before storing it.
      * @param userMetadataService user metadata service
-     * @param name       qualified name
-     * @param objectNode input metadata object node
+     * @param name                qualified name
+     * @param objectNode          input metadata object node
      * @throws InvalidMetadataException business validation exception
      */
     default void onWrite(final UserMetadataService userMetadataService,
                          final QualifiedName name, final ObjectNode objectNode)
         throws InvalidMetadataException {
     }
+
+    /**
+     * Validate ObjectNode before deleting it.
+     * @param userMetadataService user metadata service
+     * @param name                qualified name
+     * @throws InvalidMetadataException business validation exception
+     */
+    default void onDelete(final UserMetadataService userMetadataService,
+                          final QualifiedName name)
+        throws InvalidMetadataException {
+    }
 }
diff --git a/...data-mysql/src/main/java/com/netflix/metacat/metadata/mysql/MysqlUserMetadataService.java b/...data-mysql/src/main/java/com/netflix/metacat/metadata/mysql/MysqlUserMetadataService.java
@@ -242,6 +242,9 @@ private void _deleteDefinitionMetadata(
         @Nullable final List<QualifiedName> names
     ) {
         if (names != null && !names.isEmpty()) {
+            for (QualifiedName name : names) {
+                this.metadataInterceptor.onDelete(this, name);
+            }
             final SqlParameterValue[] aNames = names.stream().filter(name -> !name.isPartitionDefinition())
                 .map(n -> new SqlParameterValue(Types.VARCHAR, n))
                 .toArray(SqlParameterValue[]::new);
@@ -599,7 +602,7 @@ public void saveDefinitionMetadata(
                 name.toString());
 
         } else {
-            //apply interceptor to change the object node
+            // apply interceptor to change the object node
             if (metadata.isPresent()) {
                 this.metadataInterceptor.onWrite(this, name, metadata.get());
             }