Add sanity check on attachment filename #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 8, 2024 14:09
bhou2
force-pushed
the
dev-snapshot
branch
2 times, most recently
from
106b185
to
500cc44
Compare
natedanner
pushed a commit
to natedanner/Netflix__genie
that referenced
this pull request
May 20, 2024
* genie client integration tests: throw the exception of setting up the docker container * Add sanity check on attachment filename --------- Co-authored-by: bhou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the local filesystem to store the job attachments, the attachment filename should not contain '/' as this allows saving and potentially executing files at any path of the genie server. To avoid this security issue, we reject the attachment if its filename is illegal, i.e., containing '/'.