Adding a DataLoader without the Annotation?

[evanmalmud]

Hello trying to setup a dataloader with slightly different options than default so I made my own bean. Mainly trying to utilize the cacheMap feature. This works to a point but now

  @Bean
  public DataLoader<String, Map<String, Object>> blockDataLoader() {
    DataLoaderOptions options = new DataLoaderOptions();
    options.setBatchingEnabled(true);
    options.setCacheMap((CacheMap<?, ?>) springCacheValueCache);
    MappedBatchLoaderWithContext loader =
        new BlockDataLoader(storefrontBlockRepository, blockDataPostProcessors, scheduledPreviewService);
    return DataLoader.newMappedDataLoader(loader, options);
  }

Im having trouble making sure this dataloader is added to the the DgsDataLoaderRegistry, ultimately i cant use the "DgsDataLoader" annotation because that tries to make a second bean, and I dont see a way to add the "name" or be picked up here by the DgsAutoconfiguration.

Would love some insight on the best path forward. Essentially all I want to do is set options for a DgsDataLoader.
Im stuck on Dgs 5 btw. (Cant upgrade spring yet)

[srinivasankavitha]

Hi @evanmalmud - we don't currently have a way to customize with your own dataloader unfortunately. This is the case with both 5.x and later releases. We will need to implement support for this feature by enhancing the existing @DgsDataloader annotation to allow the cache map to be configurable. We can consider adding that in a future release, but due to other priorities we won't be able to deliver this at the moment. Feel free to open a PR and we'd be happy to review it.

[evanmalmud]

Thanks so much! This will greatly help us!

[evanmalmud]

Hey just checking in here. trying to use this new feature and I can't see to get the autoconfigruation to work and looking at the code im unsure how its supposed to.

So ive made my own bean of which should be overriding the default,
but looking here where the provider is setup its not using the bean?

dgs-framework/graphql-dgs-spring-boot-oss-autoconfigure/src/main/kotlin/com/netflix/graphql/dgs/autoconfig/DgsAutoConfiguration.kt

Line 157 in 3afa777

open fun dgsDataLoaderProvider(applicationContext: ApplicationContext): DgsDataLoaderProvider {

^ Here its not taking in an Autowire of the the OptionsProvider

and the default for it doesnt seem to be grabbing a bean either.

dgs-framework/graphql-dgs/src/main/kotlin/com/netflix/graphql/dgs/internal/DgsDataLoaderProvider.kt

Line 49 in 3afa777

private val dataLoaderOptionsProvider: DgsDataLoaderOptionsProvider = DefaultDataLoaderOptionsProvider()

I'm not super familiar with kotlin so I could be totally off base here. But im just having trouble getting this working.

Just to spell out what I've done
Created an impl of DgsDataLoaderOptionsProvider and set some value and caching!

public class DataLoaderConfig implements DgsDataLoaderOptionsProvider {

  @NotNull
  @Override
  public DataLoaderOptions getOptions(@NotNull String s, @NotNull DgsDataLoader dgsDataLoader) {
    return DataLoaderOptions.newOptions()
        .setBatchingEnabled(true)
        .setCachingEnabled(true)
        .setValueCache(new SpringValueMap<>())
        .setCacheMap(new SpringCacheMap<>());

  }

And then just created a bean of the above

  @Bean
  public DgsDataLoaderOptionsProvider dgsDataLoaderOptionsProvider() {
    return new DataLoaderConfig();
  }

It didn't seem like there was anything more to do, but im missing something.

[srinivasankavitha]

Could you try 5.6.1 ? I put in a fix for the issue you pointed out.

[evanmalmud]

Works great thank you!

[evanmalmud]

Updating the answer here for others.

[evanmalmud]

Thanks to @srinivasankavitha you can now override options for dataloaders by making a DgsDataLoaderOptionsProvider bean

Create an implementation of DgsDataLoaderOptionsProvider

public class DataLoaderConfig implements DgsDataLoaderOptionsProvider {

  @NotNull
  @Override
  public DataLoaderOptions getOptions(@NotNull String s, @NotNull DgsDataLoader dgsDataLoader) {
    return DataLoaderOptions.newOptions()
        //Whatever options you want to set
        ;
  }

Create a bean of this class that will be automatically picked up by DGS

  @Bean
  public DgsDataLoaderOptionsProvider dgsDataLoaderOptionsProvider() {
    return new DataLoaderConfig();
  }

[deep18-appdirect]

Hi @evanmalmud
I followed the same thing but I think dgsDataLoaderProvider still taking DefaultDataLoaderOptionsProvider as I have added log in DataLoaderConfig but it's never logged.
can you please let me know how exactly you are handling this.

[deep18-appdirect]

Working now...
it was not working in the version 7.1.0, need to update the version.