Build Fail Error and Warnings When Compiling

[Xylopyrographer]

Thanks for this fantastic resource!

Was compiling netatalk on macOS 13.6.1 Ventura, following the instructions at:
https://github.com/Netatalk/netatalk/wiki/Installing-Netatalk-3-on-macOS

Initial build failed with the following:

In file included from afp_dsi.c:44:
In file included from ../../include/atalk/spotlight.h:25:
../../include/atalk/dalloc.h:25:10: error: 'talloc.h' file not found with <angled> include; use "quotes" instead
#include <talloc.h>
         ^~~~~~~~~~
         "talloc.h"

Modified dalloc.h to use #include "talloc.h" which did then compile using sudo make install.

However in that process, there were a number of warnings thrown:

catsearch.c:428:17: warning: implicit conversion from 'int' to 'char' changes value from 128 to -128 [-Wconstant-conversion]
        *p++ = isdir ? FILDIRBIT_ISDIR : FILDIRBIT_ISFILE;    /* IsDir ? */
             ~         ^~~~~~~~~~~~~~~
./directory.h:59:35: note: expanded from macro 'FILDIRBIT_ISDIR'
#define FILDIRBIT_ISDIR        (1 << 7) /* is a directory */
                                ~~^~~~
1 warning generated.
.
.
.
enumerate.c:448:48: warning: implicit conversion from 'int' to 'char' changes value from 128 to -128 [-Wconstant-conversion]
        *data++ = S_ISDIR(s_path.st.st_mode) ? FILDIRBIT_ISDIR : FILDIRBIT_ISFILE;
                ~                              ^~~~~~~~~~~~~~~
./directory.h:59:35: note: expanded from macro 'FILDIRBIT_ISDIR'
#define FILDIRBIT_ISDIR        (1 << 7) /* is a directory */
                                ~~^~~~
1 warning generated.
.
.
.
fce_api.c:401:46: warning: passing 'unsigned char[4096]' to parameter of type 'char *' converts between pointers to integer types where one is of the unique plain 'char' type and the other is not [-Wpointer-sign]
            data_len = build_fce_packet(obj, iobuf, FCE_CONN_BROKEN, "", NULL, getpid(), user, 0);
                                             ^~~~~
fce_api.c:185:39: note: passing argument to parameter 'iobuf' here
                                char *iobuf,
                                      ^
fce_api.c:412:42: warning: passing 'unsigned char[4096]' to parameter of type 'char *' converts between pointers to integer types where one is of the unique plain 'char' type and the other is not [-Wpointer-sign]
        data_len = build_fce_packet(obj, iobuf, event, path, oldpath, getpid(), user, event_id);
                                         ^~~~~
fce_api.c:185:39: note: passing argument to parameter 'iobuf' here
                                char *iobuf,
                                      ^
2 warnings generated.
.
.
.
file.c:1485:26: warning: passing 'uint8_t *' (aka 'unsigned char *') to parameter of type 'char *' converts between pointers to integer types where one is of the unique plain 'char' type and the other is not [-Wpointer-sign]
                         s_vol->v_obj->dsi->commands,
                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
../../include/atalk/adouble.h:439:83: note: passing argument to parameter 'buf' here
extern int     copy_fork(int eid, struct adouble *add, struct adouble *ads, char *buf, size_t buflen);
                                                                                  ^
1 warning generated.
.
.
.
volume.c:574:40: warning: implicit conversion from 'int' to 'char' changes value from 128 to -128 [-Wconstant-conversion]
        *data = (volume->v_password) ? AFPSRVR_PASSWD : 0;
              ~                        ^~~~~~~~~~~~~~
../../include/atalk/volume.h:152:35: note: expanded from macro 'AFPSRVR_PASSWD'
#define AFPSRVR_PASSWD         (1 << 7)
                                ~~^~~~
1 warning generated.
.
.
.
cmd_dbd_scanvol.c:430:13: warning: 'strlcpy' will always overflow; destination buffer has size 1021, but size argument is 1024 [-Wbuiltin-memcpy-chk-size]
            strlcpy(pname + 3, namedup, sizeof(pname)); /* Prepends "../" */
            ^
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/secure/_string.h:112:3: note: expanded from macro 'strlcpy'
                __builtin___strlcpy_chk (dest, __VA_ARGS__, __darwin_obsz (dest))
                ^
1 warning generated.
.
.
.
main.c:130:55: warning: adding 'int' to a string does not append to the string [-Wstring-plus-int]
            if ( (strlen(dbpath) + strlen(LOCKFILENAME+1)) > (PATH_MAX - 1) ) {
                                          ~~~~~~~~~~~~^~
main.c:130:55: note: use array indexing to silence this warning
            if ( (strlen(dbpath) + strlen(LOCKFILENAME+1)) > (PATH_MAX - 1) ) {
                                                      ^
                                          &           [ ]
1 warning generated.

Above is informational at the moment as I need to compile and install this on my Libre AML-S905X-CC running Debian 12 before doing an end-to-end test to confirm it all works.

Let me know if I can provide any more info.

[rdmark]

Let me close this discussion since you raised an issue ticket for the same problem. No need for a duplicate thread.