Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import numerator! denominator! from src/QuadForm/Enumeration.jl in Hecke.jl #1863

Open
fingolfin opened this issue Sep 24, 2024 · 0 comments
Open

Import numerator! denominator! from src/QuadForm/Enumeration.jl in Hecke.jl #1863

fingolfin opened this issue Sep 24, 2024 · 0 comments

Comments

@fingolfin
Copy link
Member

And then extend them to accept ZZRingElemOrPtr and QQFieldElemOrPtr. And change the implementation

However we should tweak them to use _num_ptr and _den_ptr instead of a ccall.

Perhaps we can get rid of all calls to fmpq_denominator, fmpq_denominator_ptr, fmpq_numerator, fmpq_numerator_ptr...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fingolfin