Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add implication: integral domains are not trivial #1912

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

fingolfin
Copy link
Member

This way e.g. 'is_trivial(ZZ)' is compiled into 'reutrn false'.

If we also add a few more dedicated is_trivial methods for e.g. some quotient ring implementations, we may even be able to get by without caching this value anywhere?

This way e.g. 'is_trivial(ZZ)' is compiled into 'reutrn false'.
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.17%. Comparing base (77591f4) to head (360023c).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1912      +/-   ##
==========================================
- Coverage   88.17%   88.17%   -0.01%     
==========================================
  Files         120      120              
  Lines       30298    30297       -1     
==========================================
- Hits        26716    26714       -2     
- Misses       3582     3583       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thofma thofma merged commit c062cc1 into master Nov 26, 2024
29 checks passed
@thofma thofma deleted the mh/domains-are-not-trivial branch November 26, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants