Should Bluetooth led take precedence over error?

[shawaj]

Here I think the error LED takes precedence over the Bluetooth advertisement:

hm-config/gatewayconfig/processors/led_processor.py

Lines 19 to 30 in d859a07

	if is_raspberry_pi() or is_rockpi():
	while True:
	# Blink fast if diagnostics are not OK
	if(not self.shared_state.are_diagnostics_ok):
	self.status_led.blink(0.1, 0.1, 10, False)
	# Blink slow if advertising bluetooth
	elif(self.shared_state.is_advertising_bluetooth):
	self.status_led.blink(1, 1, 1, False)
	# Solid if diagnostics are OK and not advertising
	else:
	self.status_led.on()
	sleep(LED_REFRESH_SECONDS)

I wonder if this should be the other way around? Not sure what you think @KevinWassermann94

[KevinWassermann94]

Yeah, it should definetly be the other way around

[shawaj]

@marvinmarnold reckon we can change this?

[marvinmarnold]

Yea, reasonable change. We are also not using the concept of PF much anymore generally.

[shawaj]

@marvinmarnold do you think we should just get rid of PF here and move to checking the necessary diagnostics directly for the LED status?

[marvinmarnold]

I think they are different tickets. Bluetooth should take precedence regardless. Should also reconsider what the necessary diagnostics are. They should prob be things that impact earnings:

• Internet connected? (not just E0 or W0)
• Miner running? (not just ECC)
• Lora running? (LOR is fine)

Related to: https://github.com/NebraLtd/product-management/issues/29

[shawaj]

Good point. I'll do a PR now and open a new ticket