Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Revive Old Proposal] CMake Support #51

Open
PatchByte opened this issue Nov 6, 2023 · 10 comments
Open

[Revive Old Proposal] CMake Support #51

PatchByte opened this issue Nov 6, 2023 · 10 comments
Assignees
Labels
enhancement New feature or request

Comments

@PatchByte
Copy link
Contributor

Detailed Improvement

It is really nice to work with CMake with non Visual Studio editors.
CMake essentially is an industry standard.
CMake works nicely with integrating libraries and cross platform building.

Operating System

All of them

@PatchByte PatchByte added the enhancement New feature or request label Nov 6, 2023
@PatchByte
Copy link
Contributor Author

I would pioneer a CMake implementation, but before that I would like to know if it would get accepted.

@Nbc66
Copy link
Owner

Nbc66 commented Nov 6, 2023

Ye would be great to have but we would like to keep compatibiity with vpc aswell

A cmake implementation would be ammazing

You got the greenlight

@Nbc66 Nbc66 closed this as completed Nov 6, 2023
@Nbc66 Nbc66 reopened this Nov 6, 2023
@PatchByte
Copy link
Contributor Author

Alright it is probably going to take me a while I am trying my best tho 👍

@PatchByte
Copy link
Contributor Author

Right now I am implementing everything for windows, once the linux merge has been finished I am able to add support for linux, and osx is going to be difficult right now.

@Nbc66
Copy link
Owner

Nbc66 commented Nov 7, 2023

Nobody uses osx anymore since they droped support for 32bit apps you can ignore it

For linux support you have to talk with @DotWith about it

@PatchByte
Copy link
Contributor Author

So I am working on CMake and I noticed some weird stuff in the vvis_launcher vpc file.
My proposal is to remove:

  • StdAfx.h
  • StdAfx.cpp

And of course change the vpc config to not use precompiled headers
I don't think precompiled headers are necessary for this small projects.

Please leave your thoughts on this, and of course other persons can also leave their feedback!

@PatchByte
Copy link
Contributor Author

^ The same for vrad

@Nbc66
Copy link
Owner

Nbc66 commented Nov 15, 2023

Stdafx should stay idk what the issue would be with it if you need help figguring it out you can check out golden eye sources cmake implementation of it

@PatchByte
Copy link
Contributor Author

I am just saying it is kinda unnecessary

@PatchByte
Copy link
Contributor Author

Hey just a quick update, I am still working on it, it just takes some time 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants