Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move record_show action to versioned_datastore #602

Open
jrdh opened this issue Nov 10, 2022 · 0 comments
Open

Move record_show action to versioned_datastore #602

jrdh opened this issue Nov 10, 2022 · 0 comments
Assignees

Comments

@jrdh
Copy link
Member

jrdh commented Nov 10, 2022

Not sure why I hadn't noticed this before, but this action shouldn't be in this extension, it should be in the https://github.com/NaturalHistoryMuseum/ckanext-versioned-datastore. I noticed this because I was using the record_show action in the ckanext-iiif extension and realised using this action would require a dependency from ckanext-iiif to ckanext-nhm which makes no sense when all you're trying to do is get hold of a record.

Not sure how many of our extensions moving this will affect but if we keep the name and signature the same it shouldn't be a massive problem (🤞🏼)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

1 participant