-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#devPunk Pure CSS Tabs (Inspired by Vicente) #19
base: master
Are you sure you want to change the base?
Conversation
01f2081
to
469b990
Compare
I like the use of Fragment Identifiers, as it solves issues like memorizing the selection when the page is refreshed. For example, if the page contains an |
@VicenteRD "I'd like to evaluate the possibility of having it be a toggle-like button, in the case where there's 2 pieces of content (panels, for ease of expression) to switch between." Still a little unclear about your statement. Please let me know. |
Since it seems it's easier for me to explain things with examples, apparently, here's one, instead of me trying to give a coherent explanation 20 times: https://jsfiddle.net/92jx9yru/ . The point is to replace the JS code, if possible at all. |
@VicenteRD copy that. I'll check it out now and rebase and add a commit if we can pull it off. |
469b990
to
1796211
Compare
Ready for review @VicenteRD @brandondees @mrbernnz Mobile / Tablet / Desktop (Portrait)No "tabs" as portrait device orientation is not a good UX/UI for tabs. Notice how content is hoisted up to link list. Mobile / Tablet / Desktop (landscape)TOGGLED Mobile / Tablet / Desktop (landscape)Notice tab anchors are only visible for the non currently selected No Flexbox SupportDefault anchored list for old janky browsers that don't support flexbox |
@VicenteRD ☝️ does this look like @brandondees on your end? /cc @pachonk |
@snuggs: I think @brandondees is wearing the trollface mask right now. Fine on my end, tested it all already, works like a charm! |
That's what the live example looks like for me. I think you're using flexbox in a non-responsive way here. |
@brandondees browser vender / version? Also resolution. I'll get that fixed right up. |
chrome 57 (released stable this week) some medium-wide window size. the screenshot is 1228x637 |
Working Example
http://devpunks.herokuapp.com/tabs.html#about
/cc @brandondees