Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#devPunk Pure CSS Tabs (Inspired by Vicente) #19

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

snuggs
Copy link
Member

@snuggs snuggs commented Mar 2, 2017

@snuggs snuggs force-pushed the feature/pure-css-tabs branch 3 times, most recently from 01f2081 to 469b990 Compare March 2, 2017 06:03
@VicenteRD
Copy link

I like the use of Fragment Identifiers, as it solves issues like memorizing the selection when the page is refreshed.
With that said, I'd like to evaluate the possibility of having it be a toggle-like button, in the case where there's 2 pieces of content (panels, for ease of expression) to switch between.

For example, if the page contains an a tag with id="jobs", have the href and content of the tag change depending on which panel is (not) shown.
Thus, if by default, the panel shown is #maintenance, have #jobs with href="#calibrations" and content 'View Calibrations', or vice versa.
And when the switch is clicked, make it change to href="#maintenance" and content to 'View Maintenance Jobs', as well as switching which panel is visible (in this case, from #maintenance to #calibrations).

@snuggs
Copy link
Member Author

snuggs commented Mar 7, 2017

@VicenteRD "I'd like to evaluate the possibility of having it be a toggle-like button, in the case where there's 2 pieces of content (panels, for ease of expression) to switch between."

Still a little unclear about your statement. Please let me know.

@VicenteRD
Copy link

Since it seems it's easier for me to explain things with examples, apparently, here's one, instead of me trying to give a coherent explanation 20 times: https://jsfiddle.net/92jx9yru/ . The point is to replace the JS code, if possible at all.

@snuggs
Copy link
Member Author

snuggs commented Mar 12, 2017

@VicenteRD copy that. I'll check it out now and rebase and add a commit if we can pull it off.

@snuggs
Copy link
Member Author

snuggs commented Mar 12, 2017

Ready for review @VicenteRD @brandondees @mrbernnz
http://devpunks.herokuapp.com/tabs.html#about

Mobile / Tablet / Desktop (Portrait)

No "tabs" as portrait device orientation is not a good UX/UI for tabs.

Notice how content is hoisted up to link list.
capture d ecran 2017-03-11 a 23 06 22

Mobile / Tablet / Desktop (landscape)

capture d ecran 2017-03-11 a 22 51 59

TOGGLED Mobile / Tablet / Desktop (landscape)

Notice tab anchors are only visible for the non currently selected
capture d ecran 2017-03-11 a 22 59 43

No Flexbox Support

Default anchored list for old janky browsers that don't support flexbox

capture d ecran 2017-03-11 a 22 38 59

@brandondees
Copy link
Collaborator

screen shot 2017-03-11 at 22 16 04
looks weird to me

@snuggs
Copy link
Member Author

snuggs commented Mar 12, 2017

@VicenteRD ☝️ does this look like @brandondees on your end? /cc @pachonk

@VicenteRD
Copy link

VicenteRD commented Mar 12, 2017

@snuggs: I think @brandondees is wearing the trollface mask right now. Fine on my end, tested it all already, works like a charm!

@brandondees
Copy link
Collaborator

That's what the live example looks like for me. I think you're using flexbox in a non-responsive way here.

@snuggs
Copy link
Member Author

snuggs commented Mar 12, 2017

@brandondees browser vender / version? Also resolution. I'll get that fixed right up.

@brandondees
Copy link
Collaborator

chrome 57 (released stable this week) some medium-wide window size. the screenshot is 1228x637

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants