From 947565b444495f10bf16dae5a5a400ce3da34430 Mon Sep 17 00:00:00 2001 From: tangoyankee Date: Tue, 3 Dec 2024 16:40:27 -0500 Subject: [PATCH] Upgrade node version Upgrade node from 18 to 20 closes #241 --- .github/workflows/feature_branch.yml | 6 ++-- .github/workflows/pr_merged.yml | 6 ++-- .github/workflows/release_and_deploy.yml | 6 ++-- .nvmrc | 2 +- package-lock.json | 40 ++++++++++++++++++------ package.json | 4 +-- 6 files changed, 42 insertions(+), 22 deletions(-) diff --git a/.github/workflows/feature_branch.yml b/.github/workflows/feature_branch.yml index 148505b..cb8a58f 100644 --- a/.github/workflows/feature_branch.yml +++ b/.github/workflows/feature_branch.yml @@ -15,7 +15,7 @@ jobs: - name: Setup node env uses: actions/setup-node@v2.1.2 with: - node-version: 18.16.0 + node-version: 20.x - name: Install dependencies run: npm ci - name: Run lint @@ -31,7 +31,7 @@ jobs: - name: Setup node env uses: actions/setup-node@v2.1.2 with: - node-version: 18.16.0 + node-version: 20.x - name: Install dependencies run: npm ci - name: Run tests @@ -62,7 +62,7 @@ jobs: - name: Setup node env uses: actions/setup-node@v2.1.2 with: - node-version: 18.16.0 + node-version: 20.x - name: Install dependencies run: npm ci - name: Deploy Preview diff --git a/.github/workflows/pr_merged.yml b/.github/workflows/pr_merged.yml index 40b2a2b..30e9f2a 100644 --- a/.github/workflows/pr_merged.yml +++ b/.github/workflows/pr_merged.yml @@ -16,7 +16,7 @@ jobs: - name: Setup node env uses: actions/setup-node@v2.1.2 with: - node-version: 18.16.0 + node-version: 20.x - name: Install dependencies run: npm ci - name: Run lint @@ -32,7 +32,7 @@ jobs: - name: Setup node env uses: actions/setup-node@v2.1.2 with: - node-version: 18.16.0 + node-version: 20.x - name: Install dependencies run: npm ci - name: Run tests @@ -65,7 +65,7 @@ jobs: - name: Setup node env uses: actions/setup-node@v2.1.2 with: - node-version: 18.16.0 + node-version: 20.x - name: Install dependencies run: npm ci - name: Deploy Preview diff --git a/.github/workflows/release_and_deploy.yml b/.github/workflows/release_and_deploy.yml index 4f6232b..ca18ed5 100644 --- a/.github/workflows/release_and_deploy.yml +++ b/.github/workflows/release_and_deploy.yml @@ -13,7 +13,7 @@ jobs: - name: Setup node env uses: actions/setup-node@v2.1.2 with: - node-version: 18.16.0 + node-version: 20.x - name: Install dependencies run: npm ci - name: Run lint @@ -31,7 +31,7 @@ jobs: - name: Setup node env uses: actions/setup-node@v2.1.2 with: - node-version: 18.16.0 + node-version: 20.x - name: Install dependencies run: npm ci - name: Run tests @@ -67,7 +67,7 @@ jobs: - name: Setup node env uses: actions/setup-node@v2.1.2 with: - node-version: 18.16.0 + node-version: 20.x - name: Install dependencies run: npm ci - name: Version NPM Package diff --git a/.nvmrc b/.nvmrc index 8ddbc0c..209e3ef 100644 --- a/.nvmrc +++ b/.nvmrc @@ -1 +1 @@ -v18.16.0 +20 diff --git a/package-lock.json b/package-lock.json index d59c81f..3e6fb23 100644 --- a/package-lock.json +++ b/package-lock.json @@ -50,7 +50,7 @@ "@testing-library/react": "^13.4.0", "@testing-library/user-event": "^14.4.3", "@types/jest": "^29.0.3", - "@types/node": "^18.7.23", + "@types/node": "^20.17.9", "@types/react": "^18.0.21", "@types/react-dom": "^18.0.6", "@typescript-eslint/eslint-plugin": "^5.38.1", @@ -72,7 +72,7 @@ "webpack-cli": "^4.10.0" }, "engines": { - "node": "18.16.0" + "node": "20.x" } }, "node_modules/@adobe/css-tools": { @@ -6314,10 +6314,14 @@ } }, "node_modules/@types/node": { - "version": "18.7.23", - "resolved": "https://registry.npmjs.org/@types/node/-/node-18.7.23.tgz", - "integrity": "sha512-DWNcCHolDq0ZKGizjx2DZjR/PqsYwAcYUJmfMWqtVU2MBMG5Mo+xFZrhGId5r/O5HOuMPyQEcM6KUBp5lBZZBg==", - "devOptional": true + "version": "20.17.9", + "resolved": "https://registry.npmjs.org/@types/node/-/node-20.17.9.tgz", + "integrity": "sha512-0JOXkRyLanfGPE2QRCwgxhzlBAvaRdCNMcvbd7jFfpmD4eEXll7LRwy5ymJmyeZqk7Nh7eD2LeUyQ68BbndmXw==", + "devOptional": true, + "license": "MIT", + "dependencies": { + "undici-types": "~6.19.2" + } }, "node_modules/@types/offscreencanvas": { "version": "2019.7.0", @@ -17822,6 +17826,13 @@ "node": ">=14.0" } }, + "node_modules/undici-types": { + "version": "6.19.8", + "resolved": "https://registry.npmjs.org/undici-types/-/undici-types-6.19.8.tgz", + "integrity": "sha512-ve2KP6f/JnbPBFyobGHuerC9g1FYGn/F8n1LWTwNxCEzd6IfqTwUQcNXgEtmmQ6DlRrC1hrSrBnCZPokRrDHjw==", + "devOptional": true, + "license": "MIT" + }, "node_modules/unicode-canonical-property-names-ecmascript": { "version": "2.0.0", "resolved": "https://registry.npmjs.org/unicode-canonical-property-names-ecmascript/-/unicode-canonical-property-names-ecmascript-2.0.0.tgz", @@ -23361,10 +23372,13 @@ } }, "@types/node": { - "version": "18.7.23", - "resolved": "https://registry.npmjs.org/@types/node/-/node-18.7.23.tgz", - "integrity": "sha512-DWNcCHolDq0ZKGizjx2DZjR/PqsYwAcYUJmfMWqtVU2MBMG5Mo+xFZrhGId5r/O5HOuMPyQEcM6KUBp5lBZZBg==", - "devOptional": true + "version": "20.17.9", + "resolved": "https://registry.npmjs.org/@types/node/-/node-20.17.9.tgz", + "integrity": "sha512-0JOXkRyLanfGPE2QRCwgxhzlBAvaRdCNMcvbd7jFfpmD4eEXll7LRwy5ymJmyeZqk7Nh7eD2LeUyQ68BbndmXw==", + "devOptional": true, + "requires": { + "undici-types": "~6.19.2" + } }, "@types/offscreencanvas": { "version": "2019.7.0", @@ -32014,6 +32028,12 @@ "busboy": "^1.6.0" } }, + "undici-types": { + "version": "6.19.8", + "resolved": "https://registry.npmjs.org/undici-types/-/undici-types-6.19.8.tgz", + "integrity": "sha512-ve2KP6f/JnbPBFyobGHuerC9g1FYGn/F8n1LWTwNxCEzd6IfqTwUQcNXgEtmmQ6DlRrC1hrSrBnCZPokRrDHjw==", + "devOptional": true + }, "unicode-canonical-property-names-ecmascript": { "version": "2.0.0", "resolved": "https://registry.npmjs.org/unicode-canonical-property-names-ecmascript/-/unicode-canonical-property-names-ecmascript-2.0.0.tgz", diff --git a/package.json b/package.json index 28dac64..ef9841d 100644 --- a/package.json +++ b/package.json @@ -11,7 +11,7 @@ ], "description": "An interactive citywide equitable development tool for New York City, built by DCP Digital Services.", "engines": { - "node": "18.16.0" + "node": "20.x" }, "scripts": { "dev": "next", @@ -70,7 +70,7 @@ "@testing-library/react": "^13.4.0", "@testing-library/user-event": "^14.4.3", "@types/jest": "^29.0.3", - "@types/node": "^18.7.23", + "@types/node": "^20.17.9", "@types/react": "^18.0.21", "@types/react-dom": "^18.0.6", "@typescript-eslint/eslint-plugin": "^5.38.1",