Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with searching customers in admin #9

Open
xcom-magento opened this issue Jan 6, 2025 · 0 comments
Open

Issue with searching customers in admin #9

xcom-magento opened this issue Jan 6, 2025 · 0 comments

Comments

@xcom-magento
Copy link

xcom-magento commented Jan 6, 2025

Hello,

Our customer noticed an issue in the admin while searching customers.
For some customers there is the following error:

main.CRITICAL: TypeError: Commerce365\Customer\Model\Command\GetCustomerEmailById::execute(): Return value must be of type string, bool returned in /vendor/commerce365/module-customer/Model/Command/GetCustomerEmailById.php:24

We have fixed this by adding bool as accepted return type when no result is found. We think this is okay because in the parent method call (vendor/commerce365/module-customer/Ui/Component/Listing/Column/ParentCustomer.php::42) there is also a check when there is no email found.

Could you check this and update the module?
Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant