-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for stmatrix in the unit test HopperMatmulTest/HSH_NT_128BSwizzle #3411
Conversation
aad4d2d
to
a7eb8fd
Compare
tests/cpp/test_matmul.cpp
Outdated
fusion.addOutput(tv4); | ||
|
||
// We'll use stmatrix.x4 to store from reg to shared memory | ||
fusion.manage("st_matrix_m_tile", 16); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to be clear, does this mean we must use a macro such that getN(macro) is a multiple of 16?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, but I'd phrase as use a tile that can divide the macro.
For the m-dimension this shouldn't be a problem since it's always 64 for Hopper.
For the n-dimension, if it's not a multiple of 16, it has to a multiple of 8, and we'll have to use stmatrix.x2 where st_matrix_n_tile will be 8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also post some perf data here with smem epilogue on? The command I use is posted here: #3279
9fdca30
to
c088f18
Compare
Observations:
Without
Where With TODO: Use nsight to look at bank conflict data. |
!build |
This demonstrates the use of stmatrix in a multi-tile hopper matmul.