Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removing duplicated declaration #3722

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

removing duplicated declaration #3722

wants to merge 1 commit into from

Conversation

jjsjann123
Copy link
Collaborator

No description provided.

@jjsjann123
Copy link
Collaborator Author

!build

@github-actions GitHub Actions
Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
⚡ Recommended focus areas for review

Removed Duplicated Code

The duplicated declarations of getTvOutput and getTvInput have been removed. Verify that the remaining declarations are correct and sufficient.

TensorView* getTvOutput(const Expr*);

// Returns the first input of Expr that is a TensorView
TensorView* getTvInput(const Expr*);

// Generates the allocation domain for the given logical domain based on the
// stride order.
std::vector<IterDomain*> strideOrderToAllocation(
    const std::vector<IterDomain*>& logical_domain,

@jjsjann123 jjsjann123 marked this pull request as ready for review January 17, 2025 01:07
@jjsjann123 jjsjann123 changed the title removing duplicated code removing duplicated declaration Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jjsjann123