Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TesnsorDomain::allIDs() miss additional IDs introduced by setLoopDomain #3571

Open
naoyam opened this issue Dec 11, 2024 · 0 comments
Open
Assignees

Comments

@naoyam
Copy link
Collaborator

naoyam commented Dec 11, 2024

Will add more info. Just a placeholder for now.

  • We added initial_domain_ to make sure all IDs are detectable, but when setLoopDomain is called multiple times, the initial IDs that are set at the first call are overwritten by the second call, so the additional IDs by the first call are lost.
  • The above issue could be partially addressed by reordering the list of IDs in allIDs here, but that may not be always enough. For example, if a new non-broadcast ID is added as part of a new loop domain, and the ID is resized, traversing from the current loop domain won't find the initial additional ID.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant