Add thunder benchmarks #3394
Draft
Add thunder benchmarks #3394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!build |
|
!test --pybench |
|
Can you check how does the benchmark look like? Make sure there are no unexpected results. |
|
!test --pybench-full --dev see results here when pipeline finishes |
jacobhinkle
reviewed
Nov 15, 2024
Priya2698
force-pushed
the
pm/add_thunder_bench
branch
from
ce46a99 to
ec697f0
Compare
Priya2698
force-pushed
the
pm/add_thunder_bench
branch
from
ec697f0 to
2d9b5d3
Compare
Priya2698
force-pushed
the
pm/add_thunder_bench
branch
from
2d9b5d3 to
15a9f50
Compare
Draft
|
!test --pybench-full --dev |
Priya2698
force-pushed
the
pm/add_thunder_bench
branch
from
d69811f to
ff1373f
Compare
|
!test --pybench-full --dev |
|
!test --pybench-full --dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
thunderas an additional executor to the baseline benchmarks and the correspondingthunder.jitfunction.The following benchmarks do not have
thunderbenchmark:instancenorm: Unsupported operator in Thundertest_gelu_backward_reduction.py:.backwardcall is not supported within Thunder definitions. @IvanYashchuk has suggested using explicit backward computation for this case.Issue #2718