Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change where we print python repros to allow us to print repros prior to segfaults #3303

Merged
merged 6 commits into from
Nov 1, 2024
Merged

Change where we print python repros to allow us to print repros prior to segfaults #3303

merged 6 commits into from
Nov 1, 2024

Conversation

kevinstephano
Copy link
Collaborator

This is just a simple code reordering to put the point at which I print a repro from fd.execute() after the pybind function _execute() to before the function to allow us to print repros prior to segfaults.

tfogal
tfogal approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@tfogal tfogal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kevinstephano
Copy link
Collaborator Author

!build

@kevinstephano
Copy link
Collaborator Author

!build

@kevinstephano kevinstephano merged commit 4511aa3 into main Nov 1, 2024
35 of 36 checks passed
@kevinstephano kevinstephano deleted the move_repro_point branch November 1, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfogal tfogal tfogal approved these changes

@jjsjann123 jjsjann123 Awaiting requested review from jjsjann123

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinstephano @tfogal