You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
TensorDomain::setLoopDomain allows for a new loop domain to have extra IDs. This is meant to introduce a broadcast ID.
TensorDomain::broadcast can also be used to introduce a new broadcast ID. The added broadcast ID is kept in TensorDomain::additional_ids_.
These two interfaces have some overlap. We should consider cleaning them up and possibly merging them to a single interface.
One concern with just using setLoopDomain is that any transformation history of extra IDs in the new loop domain would not be captured in TensorDomain::allIDs unless it's part of the BFS traversal between the logical and the new loop domains.
TensorDomain::setLoopDomain
allows for a new loop domain to have extra IDs. This is meant to introduce a broadcast ID.TensorDomain::broadcast
can also be used to introduce a new broadcast ID. The added broadcast ID is kept inTensorDomain::additional_ids_
.These two interfaces have some overlap. We should consider cleaning them up and possibly merging them to a single interface.
One concern with just using
setLoopDomain
is that any transformation history of extra IDs in the new loop domain would not be captured inTensorDomain::allIDs
unless it's part of the BFS traversal between the logical and the new loop domains.Related: https://github.com/NVIDIA/Fuser/pull/2987/files#r1771874761
Tagging @naoyam and @zasdfgbnm
The text was updated successfully, but these errors were encountered: