Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider TensorDomain::setLoopDomain, TensorDomain::broadcast, TendorDomain::additional_ids_ #3000

Open
naoyam opened this issue Sep 23, 2024 · 2 comments
Assignees

Comments

@naoyam
Copy link
Collaborator

naoyam commented Sep 23, 2024

TensorDomain::setLoopDomain allows for a new loop domain to have extra IDs. This is meant to introduce a broadcast ID.

TensorDomain::broadcast can also be used to introduce a new broadcast ID. The added broadcast ID is kept in TensorDomain::additional_ids_.

These two interfaces have some overlap. We should consider cleaning them up and possibly merging them to a single interface.

One concern with just using setLoopDomain is that any transformation history of extra IDs in the new loop domain would not be captured in TensorDomain::allIDs unless it's part of the BFS traversal between the logical and the new loop domains.

Related: https://github.com/NVIDIA/Fuser/pull/2987/files#r1771874761

Tagging @naoyam and @zasdfgbnm

@kevinstephano
Copy link
Collaborator

Is this done?

@naoyam
Copy link
Collaborator Author

naoyam commented Oct 30, 2024

Not yet. These are new interfaces and I think we are still learning what they should look like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants