Ignore DID loop ids in unroll #2912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes false warning from #2888
naoyam
reviewed
Sep 5, 2024
csrc/index_compute.cpp
Outdated
| @@ -1214,7 +1214,7 @@ void ensureStaticIndexing( | |||
| continue; | |||
| } | |||
| IterDomain* loop_id = loop->iter_domain(); | |||
| if (loop->vectorize() || loop_id->isThread()) { | |||
| if (loop->vectorize() || loop_id->isThread() || loop_id->isDeviceDim()) { | |||
There was a problem hiding this comment.
Can you please change this line to:
Suggested change
| if (loop->vectorize() || loop_id->isThread() || loop_id->isDeviceDim()) { | |
| if (loop->vectorize() || isMemoryPartitionedAcross(tv->getMemoryType(), loop_id->getParallelType()) { |
Basically, what we are doing here is to figure out if each loop contributes to the index of the given tensor. If so, the loop needs to be fully unrolled to make the index static. That's important since dynamic indices would prevent the use of registers.
This particular line is just filtering out loops that won't matter. For register tensors, TID/BID parallelized loops won't matter as registers are thread local. That's obviously the case too for DID.
isMemoryPartitionedAcross is a utility function we recently added to make this logic a little easier to change and extend. If we ever add another memory type, this would help reduce code changes.
|
!build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes false warning from #2888