Cache ir_utils::allTvs as part of Fusion
#2873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This caches `ir_utils::allTvs(fusion)` as `fusion->allTvs()`. The cache is automatically invalidated whenever the TV graph topology changes; this mechanism is the same one used to recompute `Expr` uses automatically.
|
!build |
This reverts commit f89eeee.
|
Topo sort test was unhappy because it uses an unregistered expression and this approach triggers a traversal that needs dispatch. trying again. |
naoyam
reviewed
Sep 1, 2024
|
!build |
|
!build |
|
!build |
|
@naoyam let's hold off on merging this. I replaced all the uses of allTvs in the codebase and am now getting a segfault. There must still be something wrong with it. |
I'll cleanup in a follow up. |
|
!build |
naoyam
pushed a commit
that referenced
this pull request
Sep 3, 2024
Follow up to #2873 removes all uses of the ir_utils variant in favor of the Fusion variant. --------- Co-authored-by: Jacob Hinkle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caches
ir_utils::allTvs(fusion)asfusion->allTvs(). The cache is automatically invalidated whenever the TV graph topology changes; this mechanism is the same one used to recomputeExpruses automatically.