Contiguous predicate indexing #2860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!build |
naoyam
commented
Aug 27, 2024
| @@ -316,6 +316,8 @@ class AllocationDomainSetup : private kir::IrVisitor { | |||
| } | |||
| } | |||
|
|
|||
| NVF_ERROR(allocation_domains.size() == contiguity.size()); | |||
There was a problem hiding this comment.
Not related. Just for extra safety.
naoyam
commented
Aug 27, 2024
| @@ -402,6 +404,9 @@ class AllocationDomainSetup : private kir::IrVisitor { | |||
| actual_contiguity.push_back(contig.value()); | |||
| } | |||
|
|
|||
| NVF_ERROR(actual_allocation_domains.size() == actual_strides.size()); | |||
There was a problem hiding this comment.
Not related. Just for extra safety.
naoyam
commented
Aug 27, 2024
| @@ -756,8 +761,7 @@ TensorIndexer::TensorIndexer(IdModel& id_model) : id_model_(id_model) { | |||
|
|
|||
| if (isDebugDumpEnabled(DebugDumpOption::IndexingVerbose)) { | |||
| std::ofstream ofs("indexing_traversal_graph.dot", std::ofstream::trunc); | |||
| auto dot_string = | |||
| id_model_.idGraph(IdMappingMode::ALMOSTEXACT).toGraphvizDotGraph(); | |||
| auto dot_string = traversalGraph().toGraphvizDotGraph(); | |||
naoyam
commented
Aug 27, 2024
| @@ -937,22 +941,24 @@ Val* TensorIndexer::getLinearIndex( | |||
| getContigIndexFor(expr, as_consumer, alloc_info, for_loops); | |||
|
|
|||
| // Linearize the indices with strides. | |||
| Val* index = tv->fusion()->zeroVal(); | |||
| Val* linear_index = tv->fusion()->zeroVal(); | |||
|
!build |
|
@naoyam looks like this is pending a review, is there someone else that can review? Or do we need to ping Jacob on this? |
|
Pinging @jacobhinkle |
jacobhinkle
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #2752 and concludes contiguous indexing support in the new indexing system. The previous only supported tensor indexing. This one extends that for predicate indexing. The primary differences with the tensor indexing case are: