Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A minor cleanup on top of #2854 and #2855. #2859

Merged
merged 1 commit into from
Aug 27, 2024
Merged

A minor cleanup on top of #2854 and #2855. #2859

merged 1 commit into from
Aug 27, 2024

Conversation

wujingyue
Copy link
Collaborator

No description provided.

@wujingyue wujingyue marked this pull request as ready for review August 27, 2024 20:32
@wujingyue wujingyue requested a review from jjsjann123 August 27, 2024 20:32
const auto& pparams = hparams->as<PointwiseParams>();
EXPECT_TRUE(pparams->vectorize);
EXPECT_GT(pparams->unroll_factor, 1);
EXPECT_GT(getVecSizeForPointwise(fec), 1);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@wujingyue
Copy link
Collaborator Author

!build

@wujingyue wujingyue merged commit 692ee6e into main Aug 27, 2024
14 of 15 checks passed
@wujingyue wujingyue deleted the wjy/vector branch August 27, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants