Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allocation domain propagation to support reshape operations #2235

Closed
jjsjann123 opened this issue May 13, 2024 · 3 comments
Closed

allocation domain propagation to support reshape operations #2235

jjsjann123 opened this issue May 13, 2024 · 3 comments
Labels
allocation domain issues related to allocation domain support enhancement New feature or request on hold This issue should be revisited in the future

Comments

@jjsjann123
Copy link
Collaborator

allocation domain propagation should support reshape operations. @zasdfgbnm brought it up here: #2168 (comment)

Currently the propagation only maps exact iterdomains from sources to destinations. Handling reshape requires us to walk through the ValGraph and establish rules to map through split/merge/resize. Which might not be too bad to resolve if we are looking at the relationship between pair of source to destination. As @wujingyue suggested in the thread. @zasdfgbnm and @jacobhinkle were suggesting to establish a uniformed relationship table per fusion by traversing the IR. Which could used later by schedulers/segmenters to coherently establish allocation domain for boundary tensors.

I think the uniformed allocation domain sounds interesting but it's going to be hard(?!) to justify the approach at current stage. (how useful would it really be at solving problems at hand?)
Meanwhile the source to destination mapping seems like a low hanging fruit that I think can be relatively easy/quick to pull of. I'm not ruling out the alternative yet. Opening the issue here to track the progress as well as bookkeeping the alternative that we are not picking up at the moment.

@jjsjann123 jjsjann123 added the allocation domain issues related to allocation domain support label May 13, 2024
@kevinstephano
Copy link
Collaborator

Was this completed?

@jjsjann123
Copy link
Collaborator Author

Nope. Haven't got any bandwidth on this.

@jjsjann123 jjsjann123 self-assigned this Nov 4, 2024
@jjsjann123 jjsjann123 added the on hold This issue should be revisited in the future label Nov 4, 2024
@jjsjann123 jjsjann123 removed their assignment Nov 4, 2024
@jjsjann123
Copy link
Collaborator Author

moving to on hold and closing. Will revisit after Q4.

@jjsjann123 jjsjann123 added enhancement New feature or request and removed Triage labels Nov 4, 2024
@jjsjann123 jjsjann123 closed this as not planned Won't fix, can't repro, duplicate, stale Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
allocation domain issues related to allocation domain support enhancement New feature or request on hold This issue should be revisited in the future
Projects
None yet
Development

No branches or pull requests

2 participants