Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust input sizes based on device capacity #1615

Closed
Priya2698 opened this issue Jan 11, 2024 · 1 comment
Closed

Adjust input sizes based on device capacity #1615

Priya2698 opened this issue Jan 11, 2024 · 1 comment
Assignees
@Priya2698
Labels
Python Benchmarks

Comments

@Priya2698
Copy link
Collaborator

Currently, the python benchmark sizes are set to run on 80GB machines. Hence, some tests may fail on devices with smaller available memory (#1608 (comment)).

As an alternative, we can look into skipping tests when we exceed the device capacity to avoid OOM errors.
@Priya2698 Priya2698 self-assigned this Jan 11, 2024
@Priya2698
Copy link
Collaborator Author

Priya2698 commented Oct 31, 2024 •
edited
Loading

This is resolved by @jacobhinkle's PR #3252!
While we do not modify the input sizes based on the device capacity, this PR will skip tests that run into OOM errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Priya2698 Priya2698

Labels
Python Benchmarks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Priya2698