run-dev.sh does not pass RMW_IMPLEMENTATION to docker container

[delenius]

In run-dev.sh, we have
DOCKER_ARGS+=("-e ROS_DOMAIN_ID")
which is good. But it would be great to also have
DOCKER_ARGS+=("-e RMW_IMPLEMENTATION")
in case the host uses a non-default one (in my case, I have found that rmw_cyclonedds_cpp usually works better).

[hemalshahNV]

You can specify additional Docker run args using "-a | --docker_arg" like this one. No harm in adding RMW_IMPLEMENTATION if it has been defined in the host environment, I suppose.

[jekizen]

I installed on the home system: export ROS_DOMAIN_ID= <my_ID>, after running run_dev.sh, inside docker: echo $ROS_DOMAIN_ID was my_ID

docker must be running as root:
sudo systemctl enable docker.service
sudo systemctl enable docker.socket
systemctl --user disable docker.service
sudo systemctl start docker.service
sudo systemctl start docker.socket
sudo usermod -aG docker $USER