Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run_dev.sh : git lfs print_error never prints #151

Open
shawnhanna opened this issue Oct 15, 2024 · 0 comments
Open

run_dev.sh : git lfs print_error never prints #151

shawnhanna opened this issue Oct 15, 2024 · 0 comments

Comments

@shawnhanna
Copy link

Due to the set -e usage at the top of the script, when the git lfs check is run:

# Check if git-lfs is installed.
git lfs &>/dev/null
if [[ $? -ne 0 ]] ; then
    print_error "git-lfs is not insalled. Please make sure git-lfs is installed before you clone the repo."
    exit 1
fi

The check is never called because the git lfs command fails and no output is seen. I know git lfs is a prerequisite but it took me a very long time to remember that when setting up a new machine, as I had expected the error to be printed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant