Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace JSONKit with NSJSONSerialization #106

Open
jdzak opened this issue Feb 7, 2013 · 4 comments
Open

Replace JSONKit with NSJSONSerialization #106

jdzak opened this issue Feb 7, 2013 · 4 comments

Comments

@jdzak
Copy link
Contributor

jdzak commented Feb 7, 2013

JSON serialization/de-serialization was added to the native iOS libraries back in iOS 5.0 via NSJSONSerialization.

Can we replace JSONKit with NSJSONSerialization?

@yoon
Copy link
Member

yoon commented Feb 8, 2013

We could if we don't mind giving up the performance boost. JSONKit also happens to be very lightweight. Are there any other motivations to remove it?

@jdzak
Copy link
Contributor Author

jdzak commented Feb 11, 2013

The motivation was general code cleaning. I thought if there is a way to serialize/deserialize JSON using iOS native classes, we could migrate to use that instead of relying on a third-party library.

On the performance boost, I'll do some benchmarks on an iPad with a couple surveys from the NUBIC NCS project and compare JSONKit versus NSJSONSerialization. In the JSONKit performance tests, he says he ran these on a MacBook Pro with a 2.66GHz Core 2 with iOS 5.1 (I'm assuming), so there may have been optimizations done for the iPad or updates with iOS 6.0 since then. Also, it's worth mentioning that these de-serializations only happen once when survey is initially loaded, for what it's worth.

@hfossli
Copy link

hfossli commented Jun 19, 2013

Did you get any results you care to share? :)

@pkyeck
Copy link

pkyeck commented Jul 30, 2013

results would be interesting. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants