Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handlers seems to have no active function, delete module?? #48

Open
2 tasks
ambarb opened this issue Feb 2, 2021 · 2 comments
Open
2 tasks

handlers seems to have no active function, delete module?? #48

ambarb opened this issue Feb 2, 2021 · 2 comments
Labels
_commonspeckle part of V2, but strictly related to a common repo (speckle + maybe scattering) _futurepyCHX part of V2, future pyCHX once XPCS/speckle analysis is fully separated question V2 required to move towards share XPCS/speckle analysis for CHX/CSX

Comments

@ambarb
Copy link
Collaborator

ambarb commented Feb 2, 2021

Noticed a comment:

"""
Tried to allow function to change namespace did not work.
DO NOT USE
"""

This basically applies to the entire module. We should decide what to do on this.

  • Delete from _commonspeckle
  • Delete or fix for _futurepyCHX

@danielballan can you comment on this usage at SDCC versus CHX servers
I am voting for delete from _commonspeckle

@ambarb ambarb added _commonspeckle part of V2, but strictly related to a common repo (speckle + maybe scattering) _futurepyCHX part of V2, future pyCHX once XPCS/speckle analysis is fully separated question V2 required to move towards share XPCS/speckle analysis for CHX/CSX labels Feb 2, 2021
@ambarb ambarb changed the title handlers seems to have no active function handlers seems to have no active function, delete module?? Feb 2, 2021
@ambarb
Copy link
Collaborator Author

ambarb commented Feb 2, 2021

current usage is in V1 package

(base) [abarbour@box64-3 ~/Repos/pyCHX/pyCHX ✓ ] $ grep -R use_pims
chx_packages.py:from pyCHX.chx_handlers import use_pims, use_dask
chx_packages.py:use_pims(db)  #use pims for importing eiger data, register_handler 'AD_EIGER2' and 'AD_EIGER'

(base) [abarbour@box64-3 ~/Repos/pyCHX/pyCHX ✓ ] $ grep -R use_dask
chx_packages.py:from pyCHX.chx_handlers import use_pims, use_dask

maybe use_pims() is used? it is called here:

import pickle as cpk
from skimage.draw import line_aa, line, polygon
import historydict
from eiger_io.fs_handler import EigerImages
from pyCHX.chx_libs import (
np, roi, time, datetime, os, getpass, db, LogNorm, plt,tqdm, utils, Model,
multi_tau_lags, random, warnings)
from pyCHX.chx_libs import (
cmap_vge, cmap_albula, Javascript, EigerHandler, EigerHandler, pims, h5py)
from pyCHX.chx_handlers import use_pims, use_dask
use_pims(db) #use pims for importing eiger data, register_handler 'AD_EIGER2' and 'AD_EIGER'

@ambarb
Copy link
Collaborator Author

ambarb commented Feb 4, 2021

discussed with @danielballan @tankonst and we will delete handlers from _commonspeckle since handlers appears to be associated with io.

it may be required for _futurepyCHX --> pyCHX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
_commonspeckle part of V2, but strictly related to a common repo (speckle + maybe scattering) _futurepyCHX part of V2, future pyCHX once XPCS/speckle analysis is fully separated question V2 required to move towards share XPCS/speckle analysis for CHX/CSX
Projects
None yet
Development

No branches or pull requests

1 participant