Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tagged versions of tomopy and dxchange for the tomopy reconstruction example #96

Open
mrakitin opened this issue Jan 2, 2019 · 2 comments

Comments

@mrakitin
Copy link
Member

mrakitin commented Jan 2, 2019

A new version of tomopy can be installed with pip install .. See #97 which uses this new approach and installs tomopy from the master branch. Once the new version of tomopy is tagged/released (most likely https://github.com/tomopy/tomopy/releases/tag/1.2.2), we should use the tagged version and install it with:

pip install git+https://github.com/tomopy/[email protected]

Currently, we install the dxchange package from the master branch of their repo:

git+https://github.com/data-exchange/dxchange

Once the installer of dxchange is updated (see my issue data-exchange/dxchange#81), we will be able to install it with:

pip install git+https://github.com/data-exchange/[email protected]
@mrakitin
Copy link
Member Author

mrakitin commented Jan 2, 2019

There are two aspect of the issue:

  • The dxchange package needs some improvements to rely on it to automatically install the dependencies including pandas. See pip-installable package data-exchange/dxchange#81 for more details. So, at the next release of dxchange the tagged versions won't help much to avoid missing packages. A proper pip-installable package will solve the issue. Meanwhile we can just keep the dependency in our requirements.txt.
  • Using the tagged version to have a frozen set of files, so we have less failures of building the docs.

@mrakitin mrakitin changed the title Get tagged version of dxchange for tomopy reconstruction example Use tagged versions of tomopy and dxchange for the tomopy reconstruction example Jan 3, 2019
@mrakitin
Copy link
Member Author

mrakitin commented Jan 3, 2019

I updated the issue description and the title to have this change implemented for both tomopy and dxchange.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant