Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should GamsDirFinder prefer where/which gams to environment variable values? #77

Open
elainethale opened this issue Sep 10, 2020 · 2 comments

Comments

@elainethale
Copy link
Member

Currently GamsDirFinder.__find_gams looks for GAMS in this order:

  • GAMS_DIR environment variable
  • GAMSDIR environment variable
  • where / which gams
  • default install location (Windows only)

Should where/which gams come first? This would change behavior/break interface, but might be more aligned with expected behavior, in that GamsDirFinder would find the version of GAMS that is also found by the command line by default.

@jebob
Copy link

jebob commented Oct 30, 2020

I think it is a good idea. I trust PATH more than GAMSDIR.

@jebob
Copy link

jebob commented Feb 23, 2021

Should also consider speed, subprocess into where/which might be slower.

EDIT 2023-05-17: I no longer think that this will be a significant slowdown compared to anything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants