Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review notebook for loading res/comstock models #473

Open
anyaelena opened this issue Dec 12, 2023 · 5 comments · May be fixed by #477
Open

Review notebook for loading res/comstock models #473

anyaelena opened this issue Dec 12, 2023 · 5 comments · May be fixed by #477

Comments

@anyaelena
Copy link
Member

@tanushree04 can you link here please?

@tanushree04
Copy link
Contributor

Currently in the alfalfa-notebook repository (WIP) : https://github.com/NREL/alfalfa-notebooks/blob/enduseloads/enduseprofiles.ipynb

@kbenne
Copy link
Collaborator

kbenne commented Dec 18, 2023

Tasks from 12/18 meeting:

  1. Factor library functions from the example workbook and commit to NREL/Alfalfa repo. Suggest <project_root>/workflow
  2. Create a Python based example workflow with test assertions to confirm all of the key points in the workflow.
  3. Develop the following steps, factoring out library functions as needed.:
  • Define input in the form of two lists of building IDs, corresponding to ComStock and ResStock buildings.
    • Group building ID lists of increasing size. (2 buildings, 5 buildings, 50 buildings, 100 buildings)
  • Define functions for...
    • Download weather data
    • Download building model
  • Create a user defined OpenStudio Workflow that will be applied to every building ID.
  • Define a workflow Measure directory, where specific OpenStudio Measures can be added to every stock model.
  • Create a user defined Measure(s) that will add at least one sensor and one coresponding actuator.
  • Create a function to run the OpenStudio Workflow on every building ID.
  • Identify an Alfalfa resource that can run every building ID in parallel. (maybe the example workflow should receive an Alfalfa URL as an input or env var)
    • Assume the Alfalfa resource has capacity for the nunber of building IDs, or assume that it has the ability to autoscale to achieve capacity. @tijcolem
  • Run local simulation of all buildings and confirm a) simulation does not have fatal error b) any Measure tests pass (Measure tests should not depend on Alfalfa)
  • Upload completed buildings to Alfalfa and confirm success
  • Define Alfalfa simulation parameters. Start Alfalfa runs. confirm "running" status
  • Advance in loop for 24 hours.
    • Read sensor (from example Measure) and confirm that Alfalfa returns the expected value for every building.
    • Actuate corresponding actuator and confirm success.
    • Read sensor again and confirm actuator worked.
  • Stop Alfalfa runs for each building.

@tanushree04
Copy link
Contributor

tanushree04 commented Jan 9, 2024

Created branch and initial commit to download models from end use load profiles URL : https://github.com/NREL/alfalfa/tree/buildstock/workflow/lib

@kbenne
Copy link
Collaborator

kbenne commented Feb 6, 2024

@tijcolem when you're ready can you link us to your documentation for the list of input and output control points that you are expecting for each of these models?

@anyaelena
Copy link
Member Author

@kbenne are we ready to close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants