New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type piracy and method overwriting in SSS and HPS #49

Open

GabrielKS opened this issue Dec 13, 2024 · 1 comment

Contributor

GabrielKS commented Dec 13, 2024

This:

StorageSystemsSimulations.jl/src/core/feedforward.jl

Line 160 in 808b04d

PSI.get_optimization_container_key(ff) = ff.optimization_container_key

is type piracy. The exact same thing is done in HPS, so it also causes a "Method definition… overwritten" warning.

Setting aside whether we want a method this broad, is there a reason we can't put this in PSI?

Member

jd-lara commented Dec 19, 2024

This:

StorageSystemsSimulations.jl/src/core/feedforward.jl

Line 160 in 808b04d

PSI.get_optimization_container_key(ff) = ff.optimization_container_key

is type piracy. The exact same thing is done in HPS, so it also causes a "Method definition… overwritten" warning.
Setting aside whether we want a method this broad, is there a reason we can't put this in PSI?

This seems like an oversight we need to remove.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment