Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PIDGOV model #387

Merged
merged 9 commits into from
Aug 26, 2024
Merged

Add PIDGOV model #387

merged 9 commits into from
Aug 26, 2024

Conversation

rodrigomha
Copy link
Contributor

@rodrigomha rodrigomha commented Aug 23, 2024

First model for Honduras

New Test is passing locally:
image

@rodrigomha rodrigomha added the enhancement New feature or request label Aug 23, 2024
@rodrigomha rodrigomha requested a review from jd-lara August 23, 2024 23:12
@rodrigomha rodrigomha self-assigned this Aug 23, 2024
Copy link
Contributor

Performance Results

Version Precompile Time
Main 2.082558844
This Branch 2.0131648
Version Run Time
Main-Build ResidualModel 7.989606252
Main-Execute ResidualModel 17.768317495
Main-Build MassMatrixModel 0.61208161
Main-Execute MassMatrixModel 32.769044129
This Branch-Build ResidualModel 7.448160179
This Branch-Execute ResidualModel 17.216384219
This Branch-Build MassMatrixModel 0.630296331
This Branch-Execute MassMatrixModel 32.23266462

ResidualModel and MassMatrixModel performance results should be compared between versions and not between models due to the execution order of the tests

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 96.19565% with 7 lines in your changes missing coverage. Please review.

Project coverage is 86.65%. Comparing base (c94d006) to head (0778917).
Report is 7 commits behind head on main.

Files Patch % Lines
src/models/common_controls.jl 80.76% 5 Missing ⚠️
src/initialization/generator_components/init_tg.jl 97.01% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #387      +/-   ##
==========================================
- Coverage   87.36%   86.65%   -0.71%     
==========================================
  Files          65       66       +1     
  Lines        9143     9437     +294     
==========================================
+ Hits         7988     8178     +190     
- Misses       1155     1259     +104     
Flag Coverage Δ
unittests 86.65% <96.19%> (-0.71%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/models/device.jl 94.46% <100.00%> (+0.07%) ⬆️
src/models/generator_models/tg_models.jl 100.00% <100.00%> (ø)
src/post_processing/post_proc_generator.jl 89.60% <100.00%> (+0.45%) ⬆️
src/initialization/generator_components/init_tg.jl 96.10% <97.01%> (+0.31%) ⬆️
src/models/common_controls.jl 30.21% <80.76%> (+2.96%) ⬆️

... and 4 files with indirect coverage changes

Copy link
Member

@jd-lara jd-lara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have the test benchmark from other tools yet right?

@rodrigomha
Copy link
Contributor Author

We don't have the test benchmark from other tools yet right?

No :(

We should try to set-up a Python script that we can re-use for the PSSE 36 server so we can complete a bunch of tests that are without comparison

@rodrigomha rodrigomha merged commit 29ae384 into main Aug 26, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants