Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs branches and HVDC #1205

Merged
merged 2 commits into from
Dec 26, 2024
Merged

Fix bugs branches and HVDC #1205

merged 2 commits into from
Dec 26, 2024

Conversation

rodrigomha
Copy link
Contributor

Closes #1201 and #1203

@rodrigomha rodrigomha requested a review from jd-lara December 26, 2024 18:57
@rodrigomha rodrigomha changed the title Update bugs branches and HVDC Fix bugs branches and HVDC Dec 26, 2024
@jd-lara jd-lara self-assigned this Dec 26, 2024
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 6 lines in your changes missing coverage. Please review.

Project coverage is 77.15%. Comparing base (7980ac8) to head (7ab39f7).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...s_models/device_constructors/branch_constructor.jl 77.77% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1205      +/-   ##
==========================================
- Coverage   77.24%   77.15%   -0.10%     
==========================================
  Files         121      121              
  Lines       13419    13446      +27     
==========================================
+ Hits        10366    10374       +8     
- Misses       3053     3072      +19     
Flag Coverage Δ
unittests 77.15% <77.77%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...devices_models/devices/common/add_to_expression.jl 73.85% <ø> (ø)
...s_models/device_constructors/branch_constructor.jl 77.86% <77.77%> (-0.01%) ⬇️

... and 4 files with indirect coverage changes

@jd-lara jd-lara merged commit 5772e25 into main Dec 26, 2024
11 checks passed
@jd-lara jd-lara deleted the rh/update_bugs_hvdc branch December 26, 2024 19:29
Copy link
Contributor

Performance Results

Version Precompile Time
Main 4.037289005
This Branch 4.064429276
Version Build Time
Main-Build Time Precompile 64.880579312
Main-Build Time Postcompile 0.959212775
This Branch-Build Time Precompile 68.252150071
This Branch-Build Time Postcompile 1.178475693
Version Solve Time
Main-Solve Time Precompile 525.170914341
Main-Solve Time Postcompile 494.008526537
This Branch-Solve Time Precompile 463.328833462
This Branch-Solve Time Postcompile 424.472033272

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HVDC feedforward doesn't work.
2 participants