Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple issues #1136

Merged
merged 5 commits into from
Sep 4, 2024
Merged

Conversation

rodrigomha
Copy link
Contributor

Closes #1100
Closes #1103
Closes #1134
Closes #1135

@rodrigomha rodrigomha requested a review from jd-lara August 30, 2024 21:03
@rodrigomha rodrigomha changed the base branch from main to jd/fixes_area_balancing_models August 30, 2024 21:04
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 53.33333% with 14 lines in your changes missing coverage. Please review.

Project coverage is 77.52%. Comparing base (5662db1) to head (bd8b958).
Report is 9 commits behind head on jd/fixes_area_balancing_models.

Files with missing lines Patch % Lines
...ices/common/objective_function/piecewise_linear.jl 0.00% 14 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                        Coverage Diff                         @@
##           jd/fixes_area_balancing_models    #1136      +/-   ##
==================================================================
+ Coverage                           77.35%   77.52%   +0.16%     
==================================================================
  Files                                 118      118              
  Lines                               12707    12696      -11     
==================================================================
+ Hits                                 9830     9842      +12     
+ Misses                               2877     2854      -23     
Flag Coverage Δ
unittests 77.52% <53.33%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...vice_constructors/thermalgeneration_constructor.jl 98.30% <ø> (-0.01%) ⬇️
src/devices_models/devices/electric_loads.jl 95.45% <100.00%> (ø)
src/services_models/services_constructor.jl 97.60% <100.00%> (+13.90%) ⬆️
...ices/common/objective_function/piecewise_linear.jl 82.90% <0.00%> (-3.59%) ⬇️

... and 1 file with indirect coverage changes

Copy link
Contributor

Performance Results

Version Precompile Time
Main 3.186365683
This Branch 3.193631781
Version Build Time
Main-Build Time Precompile 49.854473789
Main-Build Time Postcompile 1.131573575
This Branch-Build Time Precompile 50.012686593
This Branch-Build Time Postcompile 1.203356818
Version Solve Time
Main-Solve Time Precompile 1649.840135461
Main-Solve Time Postcompile 1631.782414948
This Branch-Solve Time Precompile 518.824606283
This Branch-Solve Time Postcompile 489.459281002

@jd-lara jd-lara merged commit 82f893e into jd/fixes_area_balancing_models Sep 4, 2024
8 of 9 checks passed
@rodrigomha rodrigomha deleted the rh/fix_multiple_bugs branch September 26, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants