Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates for transmission interface #1087

Merged
merged 9 commits into from
Apr 27, 2024
Merged

Conversation

jd-lara
Copy link
Member

@jd-lara jd-lara commented Mar 16, 2024

closes #1026

@jd-lara jd-lara self-assigned this Mar 16, 2024
Copy link
Contributor

github-actions bot commented Mar 16, 2024

Performance Results

Version Precompile Time
Main 3.269840305
This Branch 3.194741751
Version Build Time
Main-Build Time Precompile 52.713127064
Main-Build Time Postcompile 2.765593777
This Branch-Build Time Precompile 54.135766412
This Branch-Build Time Postcompile 3.05297967

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link

codecov bot commented Mar 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.28%. Comparing base (5af1ed6) to head (e766959).
Report is 9 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1087      +/-   ##
==========================================
+ Coverage   80.56%   81.28%   +0.71%     
==========================================
  Files         115      115              
  Lines       12477    12486       +9     
==========================================
+ Hits        10052    10149      +97     
+ Misses       2425     2337      -88     
Flag Coverage Δ
unittests 81.28% <100.00%> (+0.71%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/core/optimization_container.jl 78.03% <100.00%> (+0.87%) ⬆️
src/core/optimizer_stats.jl 78.37% <100.00%> (+5.04%) ⬆️
src/devices_models/devices/thermal_generation.jl 90.34% <100.00%> (+0.18%) ⬆️
src/services_models/services_constructor.jl 98.97% <ø> (+10.25%) ⬆️

... and 9 files with indirect coverage changes

@jd-lara jd-lara changed the base branch from main to psy4 April 22, 2024 15:20
@jd-lara jd-lara requested a review from daniel-thom April 26, 2024 22:45
@jd-lara
Copy link
Member Author

jd-lara commented Apr 26, 2024

@daniel-thom I need this PR merged to resolve #1071 needed for M2M.

@jd-lara jd-lara merged commit 48a2733 into psy4 Apr 27, 2024
9 checks passed
@jd-lara jd-lara deleted the jd/improvements_to_interface branch May 8, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test for interfaces
2 participants