Code Duplication Throughout PowerSimulations

[GabrielKS]

This is an issue to track instances of code duplication in PowerSimulations.jl that aren't new and aren't a top priority but should be fixed at some point.

[GabrielKS]

In https://github.com/NREL-Sienna/PowerSimulations.jl/blob/main/src/devices_models/devices/common/add_to_expression.jl, there is a lot of duplication between methods of add_to_expression!, making it tedious to implement systematic changes like https://github.com/NREL-Sienna/PowerSimulations.jl/pull/1033/files#diff-f58cd1b5ce8435e93d2afbd31851717b14b829c25d93383227b2d2a5063e7e8bR365.

[GabrielKS]

In src/network_models/powermodels_interface.jl, the two methods of powermodels_network! are nearly identical.

[GabrielKS]

Lots of duplication between the _make_system_expressions! methods of src/core/optimization_container.jl

[GabrielKS]

The two branch_rate_bounds! methods in

PowerSimulations.jl/src/devices_models/devices/AC_branches.jl

Line 103 in d2ba948

function branch_rate_bounds!(

are nearly identical

[GabrielKS]

The add_constraints! method at

PowerSimulations.jl/src/devices_models/devices/AC_branches.jl

Line 269 in d2ba948

function add_constraints!(

and the one right after it are nearly identical

[GabrielKS]

(Probably not all of these are a good first issue, but some of them are)

[GabrielKS]

Lots of duplication in core/optimization_container.jl — has_container_key, get_variable, etc. My first thought is that an approach like this could help factor out differences between the various key types.

[GabrielKS]

Duplicate block starting

PowerSimulations.jl/test/test_services_constructor.jl

Line 31 in 757b45c

for (k, var_array) in IS.get_optimization_container(get_internal(model)).variables

[GabrielKS]

The various write_model_*_results! functions in store_common.jl. This speaks to a trend of code duplication across [variables, expressions, duals, etc.] — even if we hold that it's necessary to have separate functions in the public interface for each of these, we don't need nearly as much duplication in the underlying implementations.

[GabrielKS]

Same thing at

PowerSimulations.jl/src/simulation/simulation_results.jl

Line 327 in ff8d9ff

export_path = mkpath(joinpath(path, problem_results.problem, "variables"))

[GabrielKS]

PowerSimulations.jl/test/test_network_constructors.jl

Line 370 in 03f72e0

template = get_thermal_dispatch_template_network(network)

just twice but still, got an error caused by find-and-replace that implies this shouldn't be duplicated

[GabrielKS]

The two methods of get_time_series_values! at

PowerSimulations.jl/src/operation/time_series_interface.jl

Line 1 in 03f72e0

function get_time_series_values!(

are nearly identical