Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs errors #1032

Merged
merged 3 commits into from
Dec 27, 2023
Merged

Fix docs errors #1032

merged 3 commits into from
Dec 27, 2023

Conversation

rodrigomha
Copy link
Contributor

Most of the issues were for not including HydroPowerSimulations.

I added some docstrings, but there are still like 300 docstrings missing.

Closes #1030

@rodrigomha rodrigomha requested a review from jd-lara December 26, 2023 20:43
@rodrigomha rodrigomha self-assigned this Dec 26, 2023
Copy link
Contributor

Performance Results

Version Precompile Time
Main 6.93291621
This Branch 6.776728313
Version Build Time
Main-Build Time Precompile 61.754362055
Main-Build Time Postcompile 3.038769139
This Branch-Build Time Precompile 61.608870649
This Branch-Build Time Postcompile 2.961471518

Copy link

codecov bot commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bb936b8) 80.42% compared to head (8147125) 80.41%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1032      +/-   ##
==========================================
- Coverage   80.42%   80.41%   -0.02%     
==========================================
  Files         116      116              
  Lines       12478    12423      -55     
==========================================
- Hits        10036     9990      -46     
+ Misses       2442     2433       -9     
Flag Coverage Δ
unittests 80.41% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/core/auxiliary_variables.jl 84.61% <ø> (ø)
src/core/variables.jl 67.10% <ø> (-0.85%) ⬇️

... and 17 files with indirect coverage changes

@jd-lara jd-lara merged commit d81f146 into main Dec 27, 2023
9 checks passed
@jd-lara jd-lara deleted the rh/fix_docs_changes branch December 27, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Documentation Errors
2 participants