Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit aggregation metadata #27

Open
GabrielKS opened this issue Oct 9, 2024 · 0 comments
Open

Revisit aggregation metadata #27

GabrielKS opened this issue Oct 9, 2024 · 0 comments

Comments

@GabrielKS
Copy link
Collaborator

The desire to support weighted aggregations (combined with my decision to stick with DataFrames, which are fine except for this one thing) led me down an ugly path of sticking big vectors of data in column metadata, cluttering up the aggregation code. Ultimately I don't think we need to be storing this data in the object we give back to the user at all — the initial aim was to support re-aggregation, but we're not trying to support that anymore — we can store it as real columns and get rid of it as soon as aggregation is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant