Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add environment variable to override time series directory #327

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

daniel-thom
Copy link
Contributor

No description provided.

@daniel-thom daniel-thom requested a review from jd-lara February 9, 2024 00:59
@daniel-thom daniel-thom marked this pull request as draft February 9, 2024 00:59
@jd-lara jd-lara changed the base branch from main to jd/ts_series_patch February 9, 2024 01:16
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6ac9430) 79.59% compared to head (d3e5912) 79.64%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #327      +/-   ##
==========================================
+ Coverage   79.59%   79.64%   +0.04%     
==========================================
  Files          53       53              
  Lines        4230     4240      +10     
==========================================
+ Hits         3367     3377      +10     
  Misses        863      863              
Flag Coverage Δ
unittests 79.64% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/hdf5_time_series_storage.jl 91.31% <100.00%> (+0.20%) ⬆️
src/system_data.jl 90.99% <ø> (ø)

@jd-lara jd-lara changed the base branch from jd/ts_series_patch to main February 9, 2024 01:17
@daniel-thom daniel-thom marked this pull request as ready for review February 9, 2024 14:45
Copy link
Member

@jd-lara jd-lara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested in the HPC and this is a saver.

@jd-lara jd-lara merged commit 11d6415 into NREL-Sienna:main Feb 9, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants